net/frr: add BFD strict mode for BGP neighbors#5315
Open
r3m8 wants to merge 1 commit intoopnsense:masterfrom
Open
net/frr: add BFD strict mode for BGP neighbors#5315r3m8 wants to merge 1 commit intoopnsense:masterfrom
r3m8 wants to merge 1 commit intoopnsense:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
AI tools were used to create at least part of the code submitted herewith.Related issue
#5314
Describe the problem
The OPNsense FRR plugin currently lacks support for BFD Strict Mode in BGP neighbor configuration. This FRR feature ensures BGP sessions are only established when the underlying BFD session is up, preventing routing issues when physical connectivity is lost but BGP sessions remain artificially active.
Describe the proposed solution
This PR adds a "BFD Strict Mode" checkbox to the BGP neighbor configuration. The checkbox is hidden when BFD is disabled and appears when BFD is enabled, following the same pattern as OSPFv3's "Advertise Default Gateway" feature (I'm not sure this is the best way to do it, please let me know if not).
docs.frrouting.org/en/latest/bfd.html