dns/ddclient: Preserve the other address family (A/AAAA) on deSEC update (#5232)#5312
Open
max-foss wants to merge 1 commit intoopnsense:masterfrom
Open
dns/ddclient: Preserve the other address family (A/AAAA) on deSEC update (#5232)#5312max-foss wants to merge 1 commit intoopnsense:masterfrom
max-foss wants to merge 1 commit intoopnsense:masterfrom
Conversation
Member
|
it's better to add a separate implementation when specific parameters are needed which are not part of the standard |
Author
|
For a separate implementation to be worthwhile, we would need to touch the UI: Adding a checkbox to toggle the preserve behaviour (for the tiny minority who might want it), removing the unused username field, and replacing the password field with token in line with the deSEC naming scheme. Otherwise we'd just be duplicating ~100 lines of code needlessly. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Related issue
#5232
Describe the problem
Using desec-v4 and desec-v6 alongside each other (dual-stack) causes either the A- or the AAAA-record to be deleted again.
Describe the proposed solution
Here we add preserve for the other address family in line with the official documentation.
The behaviour for hostnames having either only an AAAA- or an A-record (single-stack) is unchanged.