Change deploy hook from truenas to truenas_ws#5309
Open
sopex wants to merge 4 commits intoopnsense:masterfrom
Open
Change deploy hook from truenas to truenas_ws#5309sopex wants to merge 4 commits intoopnsense:masterfrom
sopex wants to merge 4 commits intoopnsense:masterfrom
Conversation
Member
|
Is this change backwards-compatible? Will this still work for people that use older versions of TrueNAS Scale, that still use the old API? |
Contributor
Author
|
It remains a draft because it's not fully validated yet. For example, it works as a drop-in replacement for 25.10, but potentially for Core 12 you should enable websocket API. (This is a hypothetical) It remains to be seen, but for the time being, having a truenas old and truenas new does not seem necessary. I will ping you when it's ready. |
Contributor
Author
|
@fraenki Any concerns or suggestions here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
Related issue
Closes: #5271