fix: 🔨 correct pr-checks workflow to run pyright correctly and execute tests#10
Merged
Conversation
Add explicit Python 3.11 configuration, workflow read permissions, and a virtual environment setup step that installs project dependencies before running pre-commit checks. This ensures pyright and other tools can resolve installed packages during PR validation. Also update actions/setup-python to v6 and bump pyright in pre-commit to v1.1.409.
Add explicit asyncio.Task type annotations to internal watcher and consumer tasks to eliminate pyright ignore comments. Fix incorrect None check guarding watcher task cancellation during non-graceful stop. Filter None tasks before passing to asyncio.wait.
Add unit tests covering graceful monitor shutdown scenarios: - waiting for active watcher and consumer tasks to complete - cancelling pending tasks after timeout expires - handling missing consumer task without error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.