[#714] Apple 인증 자격 증명 처리를 서버 중심 구조로 전환한다#715
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트는 Apple 로그인 및 계정 연결/연결 해제 프로세스를 챌린지-응답 방식으로 개선하고, 관련 에러 처리 및 단위 테스트를 보완하는 변경사항을 담고 있습니다. 리뷰에서는 Firestore에서 사용자 이름을 가져오거나 계정 연결 및 해제 후 로컬 사용자 상태를 갱신하는 과정에서 발생할 수 있는 네트워크 오류가 전체 인증 흐름을 실패하게 만들지 않도록, 예외 처리를 추가하여 안정성을 높일 것을 제안했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
authorizationCode수신, Firebase custom token 즉시 사용으로 축소📝 작업 내용
📌 요약
hashedNonce를 사용하는 Apple challenge 인증 흐름으로 전환🔍 상세
POST /auth/apple/challenges응답의hashedNonce를ASAuthorizationAppleIDRequest.nonce에 설정challengeId와authorizationCode만 사용하는POST /auth/apple/custom-token요청 구성FirebaseAuth로그인에 즉시 사용rawNonce,identityToken, Apple access token, refresh token 처리 제거PUT /auth/apple/account-link, 연결 해제를DELETE /auth/apple/account-link로 전환currentUser.reload()를 통한 provider 상태 반영DELETE /auth/apple/access-token으로 전환AuthError로 변환📸 영상 / 이미지 (Optional)