[CLI-22] Add `op version list --project` command by cbliard · Pull Request #21 · opf/openproject-cli

cbliard · 2026-08-18T13:38:26Z

Ticket

https://community.openproject.org/wp/cli-22

What are you trying to accomplish?

The --version/--not-version work-package filters accept version IDs, but there was no way to discover them. This commit adds a command to list versions of a project for this purpose.

Screenshots

What approach did you choose and why?

Actually it adds the command back: the absence of version listing was a regression from commit 17de261, which originally resolved --version by name and printed the available-versions list as a fallback; that lookup path (and its only caller) was dropped in bbef582 when the filter switched to raw IDs.

So it rewires the dead code back, and use the printer Renderer interface to have both text and json output available.

Merge checklist

Added/updated tests
Tested live with OpenProject 17.7 and 17.8

https://community.openproject.org/wp/cli-22 The `--version`/`--not-version` work-package filters accept version IDs, but there was no way to discover them. This commit adds a command to list versions of a project for this purpose. Actually it adds the command back: the absence of version listing was a regression from commit 17de261, which originally resolved `--version` by name and printed the available-versions list as a fallback; that lookup path (and its only caller) was dropped in bbef582 when the filter switched to raw IDs.

myabc · 2026-08-18T15:59:02Z

@cbliard I'd personally find this more useful if we could sort the items (locally?) before displaying.

myabc

Looks good overall. Just a few issues:

Naming the subcommand

Many popular CLIs support a version subcommand and flag, e.g. GitHub'S CLI which supports gh version and gh --version. On the other hand, op version and op --version do different things. Are we ok with the (conceptual) collision here?

Noun first has made this more confusing IMO.

The --version flag also collides/means different things: op --version vs work-package list --project DREAM --version 2323.

I don't really have a better suggestion. Renaming the noun to something else (e.g. project-versions or releases would probably be even more confusing/problematic for users already familiar with OpenProject. Just wanted to highlight this!

Documentation

CLAUDE.md hasn't been updated to mention the subcommand.

Other issues

Claude found two additional issues with existing code, that may now become apparent:

Nil pointer panic:: dtos/version.go:33 directly dereferences dto.Embedded.Elements without a prior if dto.Embedded == nil guard (unlike dtos/budget.go:21).
Silent pagination truncation: components/resources/projects/versions.go:12 passes nil instead of requests.NewPaginatedQuery(-1, nil) for the query, leaving it at default page limits.

myabc · 2026-08-18T16:14:41Z

+	}
+}
+
+func TestListVersionsPrintsAvailableVersions(t *testing.T) {


Although an unlikely scenario in real-world usage (at least aT OP), We're missing a test for an empty version collection. This contrasts with cmd/workpackage/search.go:51 which explicitly prints No work package found for search input.

myabc · 2026-08-18T16:15:58Z

+	expected := fmt.Sprintf("%s %s\n", printer.Red(" #2"), printer.Cyan("13.0"))
+	expected += fmt.Sprintf("%s %s\n", printer.Red(" #4"), printer.Cyan("13.1"))
+	expected += fmt.Sprintf("%s %s\n", printer.Red("#43"), printer.Cyan("45.5"))


We're only testing TextRenderer. Shouldn't we exercise JsonRenderer as well?

myabc · 2026-08-18T16:17:33Z

+
+func listVersions(_ *cobra.Command, _ []string) error {
+	if err := projects.ValidateIdentifier(listProjectId); err != nil {
+		printer.ErrorText(err.Error())


Shouldn't we contextualise the error message? (as cmd/budget/list.go:25 does)

Suggested change

printer.ErrorText(err.Error())

printer.ErrorText(fmt.Sprintf("--project: %s", err.Error()))

myabc · 2026-08-18T16:22:17Z

 	"github.com/opf/openproject-cli/cmd/status"
 	"github.com/opf/openproject-cli/cmd/timeentry"
 	"github.com/opf/openproject-cli/cmd/user"
+	"github.com/opf/openproject-cli/cmd/version"


Import shadowing (claude finding): cmd/root.go:143's func Execute(version *configuration.Version) parameter strictly shadows the newly added github.com/opf/openproject-cli/cmd/version import.

Copilot

Pull request overview

Adds a new op version list --project <project> command to list a project’s versions (IDs) so users can discover values for work-package --version / --not-version filters. The change fits into the CLI’s existing noun/verb command structure and extends the printer renderer abstraction to support both text and JSON output for version listings.

Changes:

Introduces op version list --project command (wired into cmd/root.go) that fetches and prints available project versions.
Refactors printer.Versions to dispatch through the Renderer interface, adding text + JSON renderer implementations.
Updates CLI documentation to point users to the new command when using version filters.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
components/printer/versions.go	Routes version printing through `activeRenderer` instead of inline formatting.
components/printer/versions_test.go	Updates expected output to match renderer-driven text formatting.
components/printer/text_renderer.go	Adds text rendering implementation for version lists (aligned IDs).
components/printer/renderer.go	Extends `Renderer` interface with `Versions`.
components/printer/json_renderer.go	Adds JSON rendering for version lists.
cmd/version/version.go	Adds `version` noun root command and registers `list` subcommand + `--project` flag.
cmd/version/list.go	Implements version listing logic (validate project id/identifier, fetch versions, print).
cmd/version/list_test.go	Adds command-level tests for invalid project and successful listing.
cmd/root.go	Registers the new `version` command with the root CLI.
.claude/op.md	Documents new `op version list --project` usage and references it from work-package filter docs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

myabc · 2026-08-18T19:29:17Z

+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
+		response.Header().Set("Content-Type", "application/json")
+		_, _ = response.Write([]byte(`{


Not sure about this finding.

+import (
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"strings"
+	"testing"
+
+	openerrors "github.com/opf/openproject-cli/components/errors"
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+)


myabc · 2026-08-18T19:29:52Z

+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+	listProjectId = "example"
+	t.Cleanup(func() { listProjectId = "" })
+
+	if err := listVersions(nil, nil); err != nil {
+		t.Fatalf("listVersions error = %v, want nil", err)
+	}
+
+	if !strings.Contains(testingPrinter.Result, "v17") || !strings.Contains(testingPrinter.Result, "v42") {
+		t.Errorf("expected output to contain versions 'v17' and 'v42', got: %q", testingPrinter.Result)
+	}
+}


I think this is the same as #21 (comment)

myabc requested changes Aug 18, 2026

View reviewed changes

myabc requested a lite review from Copilot August 18, 2026 16:24

Copilot started reviewing on behalf of myabc August 18, 2026 16:24 View session

Copilot AI reviewed Aug 18, 2026

View reviewed changes

Navigation Menu

Uh oh!

[CLI-22] Add `op version list --project` command - #21

[CLI-22] Add `op version list --project` command#21
cbliard wants to merge 1 commit into
mainfrom
feature/cli-22-add-command-to-list-versions-in-a-project

cbliard commented Aug 18, 2026

Uh oh!

myabc commented Aug 18, 2026

Uh oh!

myabc left a comment •

edited

Loading

Uh oh!

myabc Aug 18, 2026

Uh oh!

myabc Aug 18, 2026

Uh oh!

myabc Aug 18, 2026

Uh oh!

myabc Aug 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

myabc Aug 18, 2026

Uh oh!

myabc Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

	printer.ErrorText(err.Error())
	printer.ErrorText(fmt.Sprintf("--project: %s", err.Error()))

Uh oh!

Conversation

cbliard commented Aug 18, 2026

Ticket

What are you trying to accomplish?

Screenshots

What approach did you choose and why?

Merge checklist

Uh oh!

myabc commented Aug 18, 2026

Uh oh!

myabc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

myabc Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

myabc Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

myabc Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

myabc Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

myabc Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

myabc Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

myabc left a comment •

edited

Loading