Skip to content

🌱 E2E Cleanup#2704

Open
dtfranz wants to merge 2 commits into
operator-framework:mainfrom
dtfranz:e2e-cleanup
Open

🌱 E2E Cleanup#2704
dtfranz wants to merge 2 commits into
operator-framework:mainfrom
dtfranz:e2e-cleanup

Conversation

@dtfranz
Copy link
Copy Markdown
Contributor

@dtfranz dtfranz commented May 14, 2026 •
edited
Loading

  • Fix undefined steps causing HTTPProxy tests to be skipped
  • Set "Strict" flag for godog by default to avoid undefined steps slipping by in the future
  • Fix concurrent test run requiring two ctrl-c's to terminate
  • Use parentheses instead of brackets in go test calls for E2E_TIMEOUT for consistency/correctness
  • Fix ambiguous step definitions

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@dtfranz
E2E Cleanup
9fe8844 
- Fix undefined steps causing HTTPProxy tests to be skipped
- Set "Strict" flag for godog by default to avoid undefined steps slipping by in the future
- Fix concurrent test run requiring two ctrl-c's to terminate
- Use parentheses instead of brackets in go test calls for E2E_TIMEOUT for consistency/correctness

Signed-off-by: Daniel Franz <dfranz@redhat.com>
Copilot AI review requested due to automatic review settings May 14, 2026 07:33
@openshift-ci openshift-ci Bot requested a review from fgiudici May 14, 2026 07:33
@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f324628
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6a066d12276f3d0008885905
😎 Deploy Preview https://deploy-preview-2704--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci Bot requested a review from pedjak May 14, 2026 07:33
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtfranz
Copy link
Copy Markdown
Contributor Author

dtfranz commented May 14, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2026
Copilot AI reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings May 15, 2026 00:20
Copilot AI reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comment thread test/e2e/features_test.go
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.30%. Comparing base (f120442) to head (f324628).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
+ Coverage   68.07%   68.30%   +0.22%     
==========================================
  Files         145      145              
  Lines       10698    10698              
==========================================
+ Hits         7283     7307      +24     
+ Misses       2886     2863      -23     
+ Partials      529      528       -1
Flag Coverage Δ
e2e 37.33% <ø> (+0.44%) ⬆️
experimental-e2e 52.90% <ø> (+0.24%) ⬆️
unit 53.80% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dtfranz
Fix ambiguous step definitions
f324628 
Signed-off-by: Daniel Franz <dfranz@redhat.com>
@dtfranz dtfranz changed the title 🌱 WIP: E2E Cleanup 🌱 E2E Cleanup May 15, 2026
@dtfranz
Copy link
Copy Markdown
Contributor Author

dtfranz commented May 15, 2026

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@fgiudici fgiudici Awaiting requested review from fgiudici

@pedjak pedjak Awaiting requested review from pedjak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtfranz