-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ReplayWeb.page URL link #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,6 +15,7 @@ import { getSharedArchives, setSharedArchives } from "./localstorage"; | |||||||||||||||||||||||||||||||||||||||||||||||
| import { webtorrentClient as client } from "./global-webtorrent"; | ||||||||||||||||||||||||||||||||||||||||||||||||
| import { state } from "lit/decorators.js"; | ||||||||||||||||||||||||||||||||||||||||||||||||
| import { isUrlInSkipList } from "./utils"; | ||||||||||||||||||||||||||||||||||||||||||||||||
| import { REPLAY_BASE_URL } from "./consts"; | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| import { | ||||||||||||||||||||||||||||||||||||||||||||||||
| getLocalOption, | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -512,15 +513,20 @@ class ArgoViewer extends LitElement { | |||||||||||||||||||||||||||||||||||||||||||||||
| const magnetURI = torrent.magnetURI; | ||||||||||||||||||||||||||||||||||||||||||||||||
| console.log("Seeding WACZ file via WebTorrent:", magnetURI); | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| const replayLink = `${REPLAY_BASE_URL}/?source=${encodeURIComponent( | ||||||||||||||||||||||||||||||||||||||||||||||||
| magnetURI, | ||||||||||||||||||||||||||||||||||||||||||||||||
| )}`; | ||||||||||||||||||||||||||||||||||||||||||||||||
| // Copy to clipboard | ||||||||||||||||||||||||||||||||||||||||||||||||
| navigator.clipboard | ||||||||||||||||||||||||||||||||||||||||||||||||
| .writeText(magnetURI) | ||||||||||||||||||||||||||||||||||||||||||||||||
| .writeText(replayLink) | ||||||||||||||||||||||||||||||||||||||||||||||||
| .then(() => { | ||||||||||||||||||||||||||||||||||||||||||||||||
| alert(`Magnet link copied to clipboard:\n${magnetURI}`); | ||||||||||||||||||||||||||||||||||||||||||||||||
| alert( | ||||||||||||||||||||||||||||||||||||||||||||||||
| `ReplayWeb.page copied to clipboard (just paste it in the address bar):\n${replayLink}`, | ||||||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||||||
| }) | ||||||||||||||||||||||||||||||||||||||||||||||||
| .catch((err) => { | ||||||||||||||||||||||||||||||||||||||||||||||||
| console.error("Failed to copy magnet link:", err); | ||||||||||||||||||||||||||||||||||||||||||||||||
| alert(`Magnet Link Ready:\n${magnetURI}`); | ||||||||||||||||||||||||||||||||||||||||||||||||
| alert(`ReplayWeb.page Ready:\n${replayLink}`); | ||||||||||||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
500
to
530
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion: The alert message says "Magnet link copied" but you're actually copying a ReplayWeb.page URL. Update the message to accurately reflect what's being copied to avoid user confusion. [general, importance: 8]
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| const existing = await getSharedArchives(); | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The hardcoded URL appears to be a development or staging environment. For production code, consider using a configuration variable or environment variable to make the base URL configurable across different environments. [general, importance: 7]