Update libzim 9.7.0#201
Conversation
|
Didn't build or test this locally, waiting for the github workflow to do that. |
|
@kelvinhammond Thank you, Putting @benoit74 as reviewer for the new alias related code. But first we need to fix the CI. |
Sorry, I was still in progress. Check now. |
benoit74
left a comment
There was a problem hiding this comment.
Thank you very much!
I'm a bit surprised the addAlias method was not already implemented, but I'm glad it is now done.
Please add 2 entries (one per issue solved) to Changelog file and we are good to merge.
benoit74
left a comment
There was a problem hiding this comment.
Please also rewrite commits so that we have only 2 commits on top of main branch, one per issue solved, with appropriate CHANGELOG entry attached to each of them.
ea5ecc0 to
60f555f
Compare
|
I've reordered commits + assigned changelog changes to correct commit. I'll merge once CI is green |
Sorry, I was a bit busy to get to this. |
git rebase |
|
|
No worries, you've done the hard work, it was easy to complete |
Fixes #199
Fixes #200