Skip to content

Update libzim 9.7.0#201

Merged
benoit74 merged 4 commits into
mainfrom
update_libzim9.7.0
May 19, 2026
Merged

Update libzim 9.7.0#201
benoit74 merged 4 commits into
mainfrom
update_libzim9.7.0

Conversation

@kelvinhammond
Copy link
Copy Markdown
Collaborator

@kelvinhammond kelvinhammond commented May 11, 2026

Fixes #199
Fixes #200

  • Added missing addAlias
  • Bumped libzim to 9.7.0

@kelvinhammond kelvinhammond requested a review from kelson42 May 11, 2026 13:55
@kelvinhammond
Copy link
Copy Markdown
Collaborator Author

Didn't build or test this locally, waiting for the github workflow to do that.

@kelson42 kelson42 requested a review from benoit74 May 11, 2026 13:56
@kelson42
Copy link
Copy Markdown
Contributor

@kelvinhammond Thank you, Putting @benoit74 as reviewer for the new alias related code. But first we need to fix the CI.

@kelson42 kelson42 changed the title Update libzim9.7.0 Update libzim 9.7.0 May 11, 2026
@kelvinhammond
Copy link
Copy Markdown
Collaborator Author

@kelvinhammond Thank you, Putting @benoit74 as reviewer for the new alias related code. But first we need to fix the CI.

Sorry, I was still in progress. Check now.

Copy link
Copy Markdown
Contributor

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

I'm a bit surprised the addAlias method was not already implemented, but I'm glad it is now done.

Please add 2 entries (one per issue solved) to Changelog file and we are good to merge.

Copy link
Copy Markdown
Contributor

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rewrite commits so that we have only 2 commits on top of main branch, one per issue solved, with appropriate CHANGELOG entry attached to each of them.

@benoit74 benoit74 force-pushed the update_libzim9.7.0 branch from ea5ecc0 to 60f555f Compare May 19, 2026 11:33
@benoit74
Copy link
Copy Markdown
Contributor

I've reordered commits + assigned changelog changes to correct commit.

I'll merge once CI is green

@benoit74 benoit74 merged commit a8d5e9c into main May 19, 2026
22 checks passed
@benoit74 benoit74 deleted the update_libzim9.7.0 branch May 19, 2026 11:52
@kelvinhammond
Copy link
Copy Markdown
Collaborator Author

I've reordered commits + assigned changelog changes to correct commit.

I'll merge once CI is green

Sorry, I was a bit busy to get to this.
How did you reorder the commits? Which got commands and workflow?

@kelson42
Copy link
Copy Markdown
Contributor

I've reordered commits + assigned changelog changes to correct commit.

I'll merge once CI is green

Sorry, I was a bit busy to get to this.
How did you reorder the commits? Which got commands and workflow?

git rebase

@benoit74
Copy link
Copy Markdown
Contributor

git rebase -i more exactly. With a mix of "fixup" on some commits and then "edit" to split changelog across commits. Mostly a manual process, git rebase -i only helps to reorder commits and merge two commits (or more) into a single one.

@benoit74
Copy link
Copy Markdown
Contributor

Sorry, I was a bit busy to get to this.

No worries, you've done the hard work, it was easy to complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add addAlias to libzim Archive Use libzim 9.7.0

4 participants