Skip to content

netifd: add pending PR to fix GCC16 builds#29518

Merged
BKPepe merged 1 commit into
openwrt:masterfrom
graysky2:nlbwmon
May 27, 2026
Merged

netifd: add pending PR to fix GCC16 builds#29518
BKPepe merged 1 commit into
openwrt:masterfrom
graysky2:nlbwmon

Conversation

@graysky2
Copy link
Copy Markdown
Contributor

@graysky2 graysky2 commented May 22, 2026

📦 Package Details

Maintainer: @jow-
(You can find this by checking the history of the package Makefile.)

Description:

Add pending https://github.com/jow-/nlbwmon/pull/75

This is needed for: openwrt/openwrt#23194


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget: x86/64-glibc
  • OpenWrt Device: Intel N150

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented May 23, 2026

Demote to warning until upstream fixes const correctness in config.c.

Is there any upstream issue, which can be tracked?

@graysky2
Copy link
Copy Markdown
Contributor Author

I did not see one nor did I create one since gcc 16 here is not even a finalized PR.

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented May 26, 2026

I agree with @hauke in openwrt/openwrt#23470 (comment).
I am putting this on hold until there is issue or pull request against the upstream repo.

@graysky2
Copy link
Copy Markdown
Contributor Author

@graysky2 graysky2 changed the title nlbwmon: suppress -Werror=discarded-qualifiers netifd: add pending PR to fix GCC16 builds May 26, 2026
Add pending https://github.com/jow-/nlbwmon/pull/75

This is needed for: openwrt/openwrt#23194

Signed-off-by: John Audia <therealgraysky@proton.me>
@BKPepe BKPepe merged commit 633cd89 into openwrt:master May 27, 2026
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants