Skip to content

zabbix: fix username for ubus acls#29069

Merged
BKPepe merged 2 commits intoopenwrt:masterfrom
danielfdickinson:pr-fix-zabbix-ubus-acl
Apr 7, 2026
Merged

zabbix: fix username for ubus acls#29069
BKPepe merged 2 commits intoopenwrt:masterfrom
danielfdickinson:pr-fix-zabbix-ubus-acl

Conversation

@danielfdickinson
Copy link
Copy Markdown
Contributor

@danielfdickinson danielfdickinson commented Apr 5, 2026

📦 Package Details

Maintainer: @danielfdickinson

When we updated the zabbix agent to use username zabbix-agent
we neglected to update ubus acls for zabbix-extra-network.

Therefore update the username for the network and wifi acls.

Will close #29058 once backported to 25.12.


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT r33773-d3a905e0cd
  • OpenWrt Target/Subtarget: bcm27xx/bcm2712
  • OpenWrt Device: Raspberry Pi Compute Module 5 Rev 1.0

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

Ensure consist JSON formatting by using jq --tab . <filename>.json.

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
When we updated the zabbix agent to use username zabbix-agent
we neglected to update ubus acls for zabbix-extra-network.

Therefore update the username for the network and wifi acls.

Will close openwrt#29058 once backported to 25.12.

Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
@danielfdickinson danielfdickinson marked this pull request as ready for review April 5, 2026 11:57
@danielfdickinson
Copy link
Copy Markdown
Contributor Author

@leo-b Any chance you can verify this works for you?

@leo-b
Copy link
Copy Markdown

leo-b commented Apr 7, 2026

@leo-b Any chance you can verify this works for you?

I can confirm it works for the network discovery part (netowrt.discovery):

# zabbix_get -s 127.0.0.1 -k netowrt.discovery
lua: (command line):1: attempt to index global 'dump' (a nil value)
stack traceback:
        (command line):1: in main chunk
        [C]: ?

# cd /usr/share/acl.d/
# wget https://raw.githubusercontent.com/danielfdickinson/packages/d9ba2faca263e6ccdc1edfb01a777950523b040f/admin/zabbix/files/zabbix-network-ubus-acl.json -O zabbix-network.json
# killall -HUP ubusd

# zabbix_get -s 127.0.0.1 -k netowrt.discovery
{"data":[{"{#IF}":"br-lan", "{#NET}":"lan"},{"{#IF}":"lan1", ...}

I'm sure the wifi part will be fine too.

Thanks!
--leo

@danielfdickinson
Copy link
Copy Markdown
Contributor Author

@hnyman @BKPepe @mhei Could this be merged?

@BKPepe BKPepe merged commit 0268b7c into openwrt:master Apr 7, 2026
12 checks passed
@danielfdickinson danielfdickinson deleted the pr-fix-zabbix-ubus-acl branch April 7, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zabbix-extra-network: network discovery regression: wrong username used in ACL

3 participants