Skip to content

Fix critical SSH connection leak and task deduplication false-positive #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kartikbhartiya wants to merge 2 commits into from
Closed

Fix critical SSH connection leak and task deduplication false-positive #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b0138a
Fix critical SSH connection leak and task deduplication false-positive
kartikbhartiya May 14, 2026
2ad55d2
Merge branch 'master' into master
nemesifier May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openwisp_controller/connection/base/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ def update_config(self):
self.connector_instance.update_config()
except Exception as e:
logger.exception(e)
else:
finally:
self.disconnect()

def save(self, *args, **kwargs):
Expand Down
3 changes: 2 additions & 1 deletion openwisp_controller/connection/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,14 @@ def _is_update_in_progress(device_id, current_task_id=None):
active = current_app.control.inspect().active()
if not active:
return False
device_id_str = str(device_id)
# check if there's any other running task before adding it
# exclude the current task by comparing task IDs
for task_list in active.values():
for task in task_list:
if (
task["name"] == _TASK_NAME
and str(device_id) in task["args"]
and device_id_str in [str(arg) for arg in task.get("args", [])]
and task["id"] != current_task_id
):
return True
Expand Down
Loading