[change] Decoupled expired-user deactivation from USE_OPENWISP_RADIUS…#626
[change] Decoupled expired-user deactivation from USE_OPENWISP_RADIUS…#626CodingWithSaksham wants to merge 1 commit into
Conversation
…penwisp#587 Scheduled openwisp_users.tasks.deactivate_expired_users and expiration_reminder_email always-on in the Celery beat schedule, so user expiry handling no longer depends on the RADIUS module being enabled. Removed the obsolete deactivate_expired_users management command called from radius_tasks(). Closes openwisp#587
|
Warning Review limit reached
More reviews will be available in 13 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Scheduled
openwisp_users.tasks.deactivate_expired_usersandexpiration_reminder_emailalways-on in the Celery beat schedule, so user expiry handling no longer depends on the RADIUS module being enabled. Removed the obsoletedeactivate_expired_usersmanagement command called fromradius_tasks().Checklist
Reference to Existing Issue
Closes #587.
Description of Changes
images/common/openwisp/tasks.py: Removed the obsoletedeactivate_expired_usersmanagement command call fromradius_tasks()(the logic now lives in openwisp-users; radius 1.3 no longer ships it).tests/runtests.py: Updated the test_celery registered-task assertions: droppedopenwisp_radius.tasks.deactivate_expired_usersand added the two openwisp_users.tasks.* tasks.docs/user/settings.rst: ClarifiedCRON_DELETE_OLD_RADIUSBATCH_USERS(it deletes RADIUS batch users; expired-account deactivation is now handled by openwisp-users and no longer tied toUSE_OPENWISP_RADIUS).images/common/openwisp/celery.py: Added an always-on users_schedule to the beat schedule:openwisp_users.tasks.deactivate_expired_users(daily, 00:01)openwisp_users.tasks.expiration_reminder_email(daily, 00:05)Currently blocked by #625