Fix Caliper::Entity calling nonexistent prHintsAfter() method#3050
Conversation
|
The typo part of this is included in #3044. For the other part of this, could you open a PR targeting the |
|
It seems that the Please rebase this onto the As @Alex-Jordan said, the |
Caliper::Entity::problem_user() called $problem_user->prHintsAfter() to populate the 'showHintsAfter' event field, but the UserProblem record has no prHintsAfter accessor -- the field is showHintsAfter (used correctly for the global problem in problem()). Generating a Caliper event for a problem attempt would die with "Can't locate object method prHintsAfter". Call showHintsAfter() instead.
|
Done — rebased onto |
|
If you review and approve pull request #3044, then we can merge that. Once this receives another approval it can be merged as well. |
Summary
Caliper::Entity::problem_user()called$problem_user->prHintsAfter()topopulate the
showHintsAfterevent field, but theUserProblemrecord hasno
prHintsAfteraccessor — the field isshowHintsAfter(used correctlyin
problem()for the global problem). Generating a Caliper event for aproblem attempt would die with
Can't locate object method prHintsAfter.Call
showHintsAfter()instead.Notes
Rebased onto
WeBWorK-2.21and retargeted per review; theCaliper::ResourceIrispelling commit was dropped in favor of #3044.