For the plots.pl macro HTML encode the aria description.#1361
Closed
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Closed
For the plots.pl macro HTML encode the aria description.#1361drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
plots.pl macro HTML encode the aria description.#1361drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Conversation
This is to fix an issue reported by @somiaj in openwebwork#1322 in which a apostrophe in the description causes invalid javascript to be generated. This uses `Mojo::JSON::encode_json` to encode the text. That is the same that is used before.
drgrice1
force-pushed
the
plots-encode-aria-description
branch
from
4103cf5 to
b3bc340
Compare
Member
Author
|
By the way, this is also fixed in #1336. |
Member
Author
|
In fact, since this conflicts with that and this pull request is redundant with #1336, I am going to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to fix an issue reported by @somiaj in #1322 in which a apostrophe in the description causes invalid javascript to be generated.
This uses
Mojo::JSON::encode_jsonto encode the text. That is the same that it used before.