Skip to content

Add shadcn coverage and fix overlay, layout, and selector regressions#908

Open
jwxbond wants to merge 54 commits intomainfrom
feat/support_shadcn_new
Open

Add shadcn coverage and fix overlay, layout, and selector regressions#908
jwxbond wants to merge 54 commits intomainfrom
feat/support_shadcn_new

Conversation

@jwxbond
Copy link
Copy Markdown
Contributor

@jwxbond jwxbond commented Apr 11, 2026

Summary

  • add and refresh shadcn integration coverage and snapshots
  • fix listview overlay stacking, RTL/grid, textarea, and selector regressions found during integration testing
  • add hover fallback handling for the :focus-within + :hover integration path and update its snapshots

Testing

  • flutter test test/src/rendering/css_selectors_interactive_pseudo_test.dart --plain-name "document hover targeting falls back to nearest ancestor with target-side :hover selectors"
  • cd integration_tests && WEBF_TEST_NAME_FILTER=':focus-within combined with :hover' LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 npm run integration -- --skip-build specs/css/css-selectors/pseudo-focus-within.ts
  • targeted integration runs for listview, shadcn popover, and RTL/grid regressions during the branch work

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
use-case Ready Ready Preview, Comment Apr 12, 2026 2:11am
vue_usecase Ready Ready Preview, Comment Apr 12, 2026 2:11am

Request Review

),
);

child = SingleChildScrollView(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This impls make the list view to be a single child scroll view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants