v2.11.0-rc.1#1820
Conversation
github-actions
Bot
added
ignore-for-release
release
WalkthroughThe release candidate advances from ChangesRelease and designer updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
mockServer/package.jsonESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. packages/canvas/container/src/components/CanvasAIChat.vueOops! Something went wrong! :( ESLint: 9.39.5 Error: ESLint configuration in --config »
Referenced from: /packages/canvas/.eslintrc.cjs ... [truncated 341 characters] ... at _normalizeObjectConfigData.next () packages/canvas/container/src/components/CanvasAction.vueOops! Something went wrong! :( ESLint: 9.39.5 Error: ESLint configuration in --config »
Referenced from: /packages/canvas/.eslintrc.cjs ... [truncated 341 characters] ... at _normalizeObjectConfigData.next ()
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
packages/engine-cli/template/designer/public/mock/bundle.json (1)
730-751: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winTinyFileUpload hook properties use
language: "json"instead of"javascript"for function-type widgets.
before-add-file,before-remove,before-upload, andhttp-requestare all documented as callback/hook functions (their descriptions describe returningfalse/Promiseor implementing upload logic), yet each uses"widget": {"component": "CodeConfigurator", "props": {"language": "json"}}. Elsewhere in this same file, function-type properties consistently use"language": "javascript"(e.g. TinySlider'sformat-tooltip, TinyTreeMenu'sallow-drag/allow-drop). Using"json"here will give incorrect syntax highlighting/validation for what should be JS function code.Also applies to: 752-773, 774-795, 950-971
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/engine-cli/template/designer/public/mock/bundle.json` around lines 730 - 751, Update the CodeConfigurator language for the TinyFileUpload hook properties before-add-file, before-remove, before-upload, and http-request from "json" to "javascript", preserving their existing widget configuration and metadata.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/engine-cli/template/designer/public/mock/bundle.json`:
- Around line 338-352: Update the TinyDrawer onClose event schema so
functionInfo.params declares the documented force parameter, including its
appropriate name, type, and description, while preserving the existing return
metadata and event description.
- Around line 2783-2804: Update the NumberConfigurator props for maxShowNum so
its step permits consecutive integer counts, including odd values, while
preserving the existing defaultValue and other field configuration.
---
Nitpick comments:
In `@packages/engine-cli/template/designer/public/mock/bundle.json`:
- Around line 730-751: Update the CodeConfigurator language for the
TinyFileUpload hook properties before-add-file, before-remove, before-upload,
and http-request from "json" to "javascript", preserving their existing widget
configuration and metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: c6c41594-8f55-4ee5-8795-f8a186547b2b
📒 Files selected for processing (67)
designer-demo/package.jsonmockServer/package.jsonpackages/block-compiler/package.jsonpackages/build/vite-config/package.jsonpackages/build/vite-plugin-meta-comments/package.jsonpackages/builtinComponent/package.jsonpackages/canvas/container/src/components/CanvasAIChat.vuepackages/canvas/container/src/components/CanvasAction.vuepackages/canvas/package.jsonpackages/common/component/PluginBlockItemImg.vuepackages/common/js/import-map.jsonpackages/common/package.jsonpackages/configurator/package.jsonpackages/design-core/package.jsonpackages/engine-cli/package.jsonpackages/engine-cli/template/designer/package.jsonpackages/engine-cli/template/designer/public/mock/bundle.jsonpackages/i18n/package.jsonpackages/layout/package.jsonpackages/plugins/block/package.jsonpackages/plugins/bridge/package.jsonpackages/plugins/datasource/package.jsonpackages/plugins/help/package.jsonpackages/plugins/i18n/package.jsonpackages/plugins/materials/package.jsonpackages/plugins/model-manager/package.jsonpackages/plugins/page/package.jsonpackages/plugins/resource/package.jsonpackages/plugins/robot/package.jsonpackages/plugins/robot/src/Main.vuepackages/plugins/schema/package.jsonpackages/plugins/script/package.jsonpackages/plugins/state/package.jsonpackages/plugins/tree/package.jsonpackages/plugins/tutorial/package.jsonpackages/register/package.jsonpackages/settings/design/package.jsonpackages/settings/events/package.jsonpackages/settings/panel/package.jsonpackages/settings/props/package.jsonpackages/settings/styles/package.jsonpackages/svgs/package.jsonpackages/theme/base/package.jsonpackages/toolbars/breadcrumb/package.jsonpackages/toolbars/clean/package.jsonpackages/toolbars/collaboration/package.jsonpackages/toolbars/fullscreen/package.jsonpackages/toolbars/generate-code/package.jsonpackages/toolbars/lang/package.jsonpackages/toolbars/lock/package.jsonpackages/toolbars/logo/package.jsonpackages/toolbars/media/package.jsonpackages/toolbars/preview/package.jsonpackages/toolbars/redoundo/package.jsonpackages/toolbars/refresh/package.jsonpackages/toolbars/save/package.jsonpackages/toolbars/setting/package.jsonpackages/toolbars/themeSwitch/package.jsonpackages/toolbars/upload/package.jsonpackages/toolbars/user/package.jsonpackages/toolbars/user/src/Main.vuepackages/toolbars/view-setting/package.jsonpackages/utils/package.jsonpackages/vue-generator/package.jsonpackages/vue-to-dsl/package.jsonpackages/workspace/application-center/package.jsonpackages/workspace/template-center/package.json
3 participants
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Chores