Skip to content

Split appcred finalizer management#901

Open
Deydra71 wants to merge 1 commit into
openstack-k8s-operators:mainfrom
Deydra71:appcred-finalizer-split
Open

Split appcred finalizer management#901
Deydra71 wants to merge 1 commit into
openstack-k8s-operators:mainfrom
Deydra71:appcred-finalizer-split

Conversation

@Deydra71
Copy link
Copy Markdown
Contributor

Following the discussion in watcher-operator the AC finalizer management is now split into two phases:

  • Early phase: adds consumer finalizer to the new AC secret immediately (protects it from premature revocation)
  • Late phase: removes consumer finalizer from the old AC secret only after AllSubConditionIsTrue()

This prevents a race condition where rapid AC rotations could revoke credentials still in use by running pods. The same pattern is implemented in all service operators with application credential support.

The AC finalizer management is now split into two phases:
* Early phase: adds consumer finalizer to the new AC secret immediately (protects it from premature revocation)
* Late phase: removes consumer finalizer from the old AC secret only after `AllSubConditionIsTrue()`

This prevents a race condition where rapid AC rotations could revoke credentials still in use by running pods.

Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
@openshift-ci openshift-ci Bot requested review from dprince and stuggi May 26, 2026 05:53
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Deydra71
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Deydra71 Deydra71 requested a review from vyzigold May 26, 2026 05:54
@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4d8736f75a2c4451a66c6a307b3de6e9

openstack-k8s-operators-content-provider FAILURE in 5m 21s
telemetry-operator-multinode-cloudkitty FAILURE in 1h 51m 23s
✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 11m 20s
⚠️ telemetry-operator-multinode-default-telemetry SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ telemetry-operator-multinode-audit-logging SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
functional-tests-osp18 FAILURE in 1h 55m 28s

@Deydra71
Copy link
Copy Markdown
Contributor Author

recheck

Looks like dataplane deployment timed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant