Avoid recompressing already-compressed SOS archives#155
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 15, 2026
Conversation
fmount
commented
Jul 14, 2026
| # This option is used for CI purposes and | ||
| # is enabled by default | ||
| export SOS_DECOMPRESS=${SOS_DECOMPRESS:-1} | ||
| export SOS_DECOMPRESS=${SOS_DECOMPRESS:-0} |
Contributor
Author
There was a problem hiding this comment.
For customers we do not decompress (it takes forever for large environments), but for CI we keep decompressing. openstack-k8s-operators/ci-framework#4054 keeps cifmw aligned w/ the existing behavior.
stuggi
reviewed
Jul 15, 2026
stuggi
left a comment
stuggi
left a comment
Contributor
There was a problem hiding this comment.
looks good to me, just the comment for the new default should be updated?
When SOS_DECOMPRESS=0, SOS reports are kept as .tar.xz files. The previous archiving step ran a single XZ pass over everything, redundantly recompressing them with no size benefit and significant time cost. This patch extracts the archiving logic into a compress() function that is the very last step of the gathering process. When SOS_DECOMPRESS=0 (and SOS data is present), it only compresses non-SOS data into an intermediate XZ archive, then it bundles it with the SOS tarballs into a plain tar. Default SOS_DECOMPRESS to 0 to better match this workflow and to save time: for large environments decompress a big amount of sos reports might take a lot of time and resources. Jira: https://redhat.atlassian.net/browse/OSPRH-32765 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Contributor
|
/lgtm |
rebtoor
approved these changes
Jul 15, 2026
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Jul 15, 2026
3267c85
into
openstack-k8s-operators:main
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SOS_DECOMPRESS=0,SOSreports are kept as.tar.xzfiles.The previous archiving step ran a single
xzpass over everything, redundantly recompressing them with no size benefit and significant time cost.This patch extracts the archiving logic into a
compress()function that is the very last step of the gathering process. WhenSOS_DECOMPRESS=0(andSOSdata is present), it only compressesnon-SOSdata into an intermediatexzarchive, then it bundles it with theSOStarballs into a plaintar.In addition, the default
SOS_DECOMPRESSvalue is now0to better match this workflow and to save time: for large environments decompress a big amount of sos reports might take a lot of time and resources.Jira: https://redhat.atlassian.net/browse/OSPRH-32765