Skip to content

[reproducer] Enable CSR auto-approval when waiting for OCP stability #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abays wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[reproducer] Enable CSR auto-approval when waiting for OCP stability #4027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions roles/reproducer/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@
cifmw_openshift_adm_op: "stable"
cifmw_openshift_kubeconfig: >-
{{ (_auth_path, 'kubeconfig') | ansible.builtin.path_join }}
_openshift_adm_check_cert_approve: true

@michburk michburk Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily blocking but IIUC including this flag here means that greenfield deployments will have an additional 3 minutes of unnecessary time added as they wait for the approve_csr module to run through the complete quiet_period. Correct me if I'm wrong on that, but if that is the case, would it be possible to avoid including this flag in the greenfield case?

ansible.builtin.include_role:
name: openshift_adm

Expand Down
1 change: 1 addition & 0 deletions roles/reproducer/tasks/reuse_main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@
cifmw_openshift_adm_op: "stable"
cifmw_openshift_kubeconfig: >-
{{ (_auth_path, 'kubeconfig') | ansible.builtin.path_join }}
_openshift_adm_check_cert_approve: true
ansible.builtin.include_role:
name: openshift_adm

Expand Down
Loading