Add Octavia SKMO playbooks for amphora and network setup#3965
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8f9b484 to
e1bc8e2
Compare
|
First commit already reviewed in #3956 |
| set -xe -o pipefail | ||
| oc debug node/{{ item }} -- chroot /host ip link set br-octavia up | ||
| loop: "{{ cifmw_skmo_master_nodes }}" | ||
| changed_when: false |
There was a problem hiding this comment.
(blocking) suggestion: I think it's safe to remove this changed_when.
it was merged. |
e1bc8e2 to
e1304ee
Compare
|
removed merged commit. |
| PATH: "{{ cifmw_path }}" | ||
| ansible.builtin.shell: | | ||
| set -xe -o pipefail | ||
| oc debug node/{{ item }} -- chroot /host ip link set br-octavia up |
There was a problem hiding this comment.
I don't remember that we had to do that in other jobs, is it something specific to this job?
e1304ee to
9c05293
Compare
9c05293 to
f1da49a
Compare
f1da49a to
8c6b432
Compare
8c6b432 to
c75c2f1
Compare
c75c2f1 to
dc7396d
Compare
|
Rebased so test project can run with the latest changes |
1da5cf6 to
d8dd47e
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 36s |
d8dd47e to
a69c6c2
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 4m 01s |
|
recheck |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 4m 16s |
a69c6c2 to
0fa2a0d
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 4m 29s |
…y issues Add Octavia network-values fixes, federation ordering, SKMO EDPM stale deployment hooks, and va-multi-skmo reproducer updates. Signed-off-by: Ade Lee <alee@redhat.com> Assisted-by: Claude Opus 4.6
0fa2a0d to
1105b42
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 51s |
|
recheck |
|
/lgtm for Octavia |
| hooks: | ||
| - id: ansible-lint | ||
| additional_dependencies: | ||
| - ansible-core==2.15.13 |
There was a problem hiding this comment.
don't think that is right to add it in one commit, one PR.
There was a problem hiding this comment.
Aight, so you suggest putting it to a single/separate PR, and merge first?
There was a problem hiding this comment.
i agree with @danpawlik here, is completely unrelated to the pr itself.
Please create another pr for this and add a meaningful commit message (aka, explain the reason behind the version pin)
| hooks: | ||
| - id: ansible-lint | ||
| additional_dependencies: | ||
| - ansible-core==2.15.13 |
There was a problem hiding this comment.
i agree with @danpawlik here, is completely unrelated to the pr itself.
Please create another pr for this and add a meaningful commit message (aka, explain the reason behind the version pin)
Skip wait/approve when the RHSSO operator CSV is already Succeeded and only approve unapproved install plans when a fresh install is needed. Signed-off-by: Ade Lee <alee@redhat.com> Assisted-by: Claude Opus 4.6
1105b42 to
13e493d
Compare
6 participants
Add SKMO OVN Octavia Tempest support for leaf region
Add EDPM recreate hook and extend network-values templates for Octavia
NAD generation. Leaf-region Tempest config lives in ci-framework-jobs
05-tests.yaml; reproducer uses post_tests: [] like the uni job.
Depends-On: openstack-k8s-operators/architecture#759
Signed-off-by: Ade Lee alee@redhat.com
Assisted-by: Claude Opus 4.6