Adjusts to test eBGP (different ASN values)#3900
Conversation
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 12m 20s |
0308fa9 to
a6d7849
Compare
a6d7849 to
2d57366
Compare
2d57366 to
4b6cfae
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 6m 51s |
4b6cfae to
030c46a
Compare
030c46a to
39f8b73
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
39f8b73 to
f08dd95
Compare
|
This PR is stale because it has been for over 15 days with no activity. |
f08dd95 to
7675794
Compare
7675794 to
9029653
Compare
9029653 to
ca9de8f
Compare
ca9de8f to
1d67143
Compare
m-blue-m
added
Ready For Review
and removed
do-not-merge/work-in-progress
do-not-merge/hold
labels
Allow parameterized leaf ASN and downlink peering mode in the leaf FRR template. Conditional graceful-shutdown and route-reflector-client for iBGP racks only, since FRR rejects route-reflector-client on eBGP peers (different ASN) and graceful-shutdown is not applicable for eBGP during normal operation. Adds ebgp_racks and ebgp_leaf_asn variables to control which racks use eBGP and their leaf ASN (formula: 64999 - rack_id). Applies to both IPv4 and IPv6 address families. Adds bgp_dt02 template directory for ci_gen_kustomize_values. Related: OSPRH-28085 Assisted-By: Claude Code Signed-off-by: Maor Blaustein <mblue@redhat.com>
1d67143 to
057d3be
Compare
| bgp router-id {{_router_id}} | ||
| {% endif %} | ||
| bgp log-neighbor-changes | ||
| {% if _downlink_as_mode == 'internal' %} |
There was a problem hiding this comment.
I think we were not sure whether this change is really needed.
Is it needed or can you remove it?
There was a problem hiding this comment.
Right.
In theory and according to FRR docs, it is very likely to disrupt eBGP and already verified manually when this is removed that a few different tests pass in pod, but we thought it could relate to CI deployment service restart issues.
Currently waiting for testproject results which include current state of code, so I guess we can wait for it before merging, or if will fail and root caused to this, then of course I'll remove it.
3 participants
Allow parameterized ASN (leaf_asn), downlink mode (downlink_remote_as). Conditional route-reflector-client for iBGP only.
Sets downlink_remote_as and leaf_asn according to destined ebgp_racks and ebgp_leaf_asn variables (changes both IPv4 and IPv6 renders).
Related: OSPRH-28085
Assisted-By: Claude Code