[devscripts] use boolean conditionals in devscripts tasks#3801
[devscripts] use boolean conditionals in devscripts tasks#3801fultonj wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
Newer Ansible requires conditionals to resolve to explicit boolean values rather than relying on truthiness of other types. 132_extend_lvm.yml: replace bare dict checks for ansible_lvm and root_mount_data with `| length > 0`. 137_custom_install.yml: remove erroneous double quotes wrapping the version test expression, which caused it to be evaluated as a non-empty string (always True) instead of a boolean. Signed-off-by: John Fulton <fulton@redhat.com> Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
My deployment fails without this patch when I use the following ansible: |
|
I think we need to push the second file change! |
Actually is here: #3800 |
|
Let's change the commit message and we should be good to go. |
Agree with @evallesp to avoid confusion, otherwise LGTM. |
Newer Ansible requires conditionals to resolve to explicit boolean values rather than relying on truthiness of other types.
132_extend_lvm.yml: replace bare dict checks for ansible_lvm and root_mount_data with
| length > 0.137_custom_install.yml: remove erroneous double quotes wrapping the version test expression, which caused it to be evaluated as a non-empty string (always True) instead of a boolean.
Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com