-
Notifications
You must be signed in to change notification settings - Fork 144
[kustomize_deploy] Install catalog source before Subscription #3609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[kustomize_deploy] Install catalog source before Subscription #3609
Conversation
danpawlik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense. Let's see if tests would pass. Also uni jobs would be welcome to trigger...
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56ecd04ecb764b1f91e46e5caa184d8b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 15s |
|
recheck |
bf25bdd to
93b10ec
Compare
5c6cbcb to
efb05f4
Compare
Move CatalogSource creation task to run before applying OLM Subscriptions to ensure custom catalog is available when the Subscription is created. Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
efb05f4 to
ab59b2d
Compare
rebtoor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally ok with this change but I'm testing it downstream.
I'll update my review as soon as I have the results.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move catalog source creation task to run before applying OLM Subscriptions to ensure custom catalog is available when the Subscription is created.
Additionally, disable the redhat-operators catalog source in OperatorHub when catalog override is enabled to prevent conflicts with the custom catalog source.
Assisted-by: Cursor(claude-4.5-sonnet)