Skip to content

Conversation

@holser
Copy link
Contributor

@holser holser commented Jan 20, 2026

Move catalog source creation task to run before applying OLM Subscriptions to ensure custom catalog is available when the Subscription is created.

Additionally, disable the redhat-operators catalog source in OperatorHub when catalog override is enabled to prevent conflicts with the custom catalog source.

Assisted-by: Cursor(claude-4.5-sonnet)

Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Let's see if tests would pass. Also uni jobs would be welcome to trigger...

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56ecd04ecb764b1f91e46e5caa184d8b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 15s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 32m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 40s
cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 13m 37s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 11s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 12s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 56s
✔️ cifmw-molecule-kustomize_deploy SUCCESS in 4m 07s

@danpawlik
Copy link
Contributor

recheck

@holser holser force-pushed the install_catalog_before_subscription branch 2 times, most recently from bf25bdd to 93b10ec Compare January 20, 2026 20:43
@holser holser requested a review from rebtoor January 20, 2026 20:48
@holser holser force-pushed the install_catalog_before_subscription branch from 5c6cbcb to efb05f4 Compare January 20, 2026 21:03
Move CatalogSource creation task to run before applying OLM
Subscriptions to ensure custom catalog is available when the
Subscription is created.

Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
@holser holser force-pushed the install_catalog_before_subscription branch from efb05f4 to ab59b2d Compare January 20, 2026 21:05
Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally ok with this change but I'm testing it downstream.

I'll update my review as soon as I have the results.

@rebtoor
Copy link
Contributor

rebtoor commented Jan 21, 2026

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants