install cephadm on all nodes #3552
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
katarimanojk
force-pushed
the
fix_missing_packages_in_cephnodes
branch
from
2241460 to
0c9047f
Compare
|
This PR is stale because it has been for over 15 days with no activity. |
katarimanojk
force-pushed
the
fix_missing_packages_in_cephnodes
branch
from
0c9047f to
a27c4f4
Compare
fultonj
left a comment
fultonj
left a comment
There was a problem hiding this comment.
Would you please consider a few small changes?
katarimanojk
force-pushed
the
fix_missing_packages_in_cephnodes
branch
from
a27c4f4 to
e90853a
Compare
fmount
left a comment
fmount
left a comment
There was a problem hiding this comment.
Other than minor things that we can even address in a follow up, the patch seems good to go. @katarimanojk let me know if you have other iterations on it, otherwise we can land it.
katarimanojk
force-pushed
the
fix_missing_packages_in_cephnodes
branch
from
e90853a to
483825e
Compare
@fmount Thanks for the suggestions, update the patch now |
| cifmw_admin_distribute_private_key: true | ||
| no_log: "{{ cifmw_nolog | default(true) | bool }}" | ||
|
|
||
| - name: Ceph prerequisites |
There was a problem hiding this comment.
I'm ok with this patch, so we can land it.
While reviewing it I was thinking about the idea of installing cephadm to all the ceph nodes by default.
The advantage would be to have ceph cli access everywhere, which makes things easier in case you redeploy daemons on a different target node.
If we install cephadm everywhere (the ceph tools repo should be available in the EDPM nodes), we could remove the when condition and always run the prerequisites playbook.
However, because we use this playbook for several use cases, I think it's safe to land this patch as it is and discuss about these thoughts for a follow up patch that should be extensively tested with the existing Ceph related use cases.
|
@katarimanojk as per the recent failures I'm wondering if this patch should be extended to install not only cephadm but also the missing requirements [1]. |
katarimanojk
force-pushed
the
fix_missing_packages_in_cephnodes
branch
from
483825e to
f17e5c7
Compare
|
New changes are detected. LGTM label has been removed. |
@fmount i just updated the patch to install missing package, please review the latest change |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e5db0069d16f45ca8a97bf33b950d6fe ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 33s |
hooks/playbooks/ceph.yml
Outdated
| hosts: "{{ cifmw_ceph_target | default('computes') }}" | ||
| gather_facts: false | ||
| become: true | ||
| when: cifmw_cephadm_install_on_all_nodes | default(false) | bool |
There was a problem hiding this comment.
nope.
ERROR! 'when' is not a valid attribute for a Play
The error appears to be in '/home/zuul/src/github.com/openstack-k8s-operators/ci-framework/hooks/playbooks/ceph.yml': line 101, column 3, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
- name: Ceph prerequisites
^ here
There was a problem hiding this comment.
My bad, i missed it, thanks for pointing it. I will fix it in the follow up patch.
For adoption scenarios with external Ceph, cephadm and dependent packages may be missing on nodes. Add separate play controlled by cifmw_cephadm_install_on_all_nodes to install on all nodes when needed (defaults to false for standard deployments).
katarimanojk
force-pushed
the
fix_missing_packages_in_cephnodes
branch
from
f17e5c7 to
3b24394
Compare
4 participants
No description provided.