Add per-node config (ansibleHost, networks, fixedIP) to all NFV scena…#756
Add per-node config (ansibleHost, networks, fixedIP) to all NFV scena…#756mnietoji wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mnietoji The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
013e158 to
4530e73
Compare
|
The generated output looks mostly correct. E.g. if I look at the [johfulto@laptop architecture{fix/nfv-nodes-config}]$ diff -u /tmp/cr-review/nfv/2nodesets-ns1-before.yaml /tmp/cr-review/nfv/2nodesets-ns1-after.yaml
--- /tmp/cr-review/nfv/2nodesets-ns1-before.yaml 2026-05-15 17:14:14.581082125 -0400
+++ /tmp/cr-review/nfv/2nodesets-ns1-after.yaml 2026-05-15 17:14:14.723085230 -0400
@@ -224,7 +224,20 @@
subnetName: subnet1
nodes:
edpm-compute-0:
+ ansible:
+ ansibleHost: 192.168.122.100
hostName: edpm-compute-0
+ networks:
+ - defaultRoute: true
+ fixedIP: 192.168.122.100
+ name: ctlplane
+ subnetName: subnet1
+ - name: internalapi
+ subnetName: subnet1
+ - name: storage
+ subnetName: subnet1
+ - name: tenant
+ subnetName: subnet1
preProvisioned: false
services:
- bootstrap
[johfulto@laptop architecture{fix/nfv-nodes-config}]$ OR [johfulto@laptop architecture{fix/nfv-nodes-config}]$ diff -u /tmp/cr-review/nfv/2nodesets-ns2-before.yaml /tmp/cr-review/nfv/2nodesets-ns2-after.yaml
--- /tmp/cr-review/nfv/2nodesets-ns2-before.yaml 2026-05-15 17:14:14.651083656 -0400
+++ /tmp/cr-review/nfv/2nodesets-ns2-after.yaml 2026-05-15 17:14:14.800086914 -0400
@@ -224,7 +224,20 @@
subnetName: subnet1
nodes:
edpm-compute-1:
+ ansible:
+ ansibleHost: 192.168.122.101
hostName: edpm-compute-1
+ networks:
+ - defaultRoute: true
+ fixedIP: 192.168.122.101
+ name: ctlplane
+ subnetName: subnet1
+ - name: internalapi
+ subnetName: subnet1
+ - name: storage
+ subnetName: subnet1
+ - name: tenant
+ subnetName: subnet1
preProvisioned: false
services:
- bootstrap
[johfulto@laptop architecture{fix/nfv-nodes-config}]$ |
|
Should we get someone else form the NFV team to review before merging? |
|
I agree with @fultonj's comments, but otherwise LGTM |
…rios Define per-node networks with fixedIP in all NFV nodeset values so that each compute node gets a known IP address on the ctlplane network. Without this, nodes are generated with only hostName and the resulting IP is unpredictable. Extends the pattern already present in nfv-ovs-dpdk-sriov-hci to: ovs-dpdk, ovs-dpdk-sriov, sriov, nfv-ovs-dpdk-sriov-2nodesets, and nfv-ovs-dpdk-sriov-networker. Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4530e73 to
50c992b
Compare
|
@fultonj @Jaganathancse @abays @sfitzger |
Add per-node config (ansibleHost, networks, fixedIP) to all NFV scenarios
Define per-node networks with fixedIP in all NFV nodeset values so that
each compute node gets a known IP address on the ctlplane network.
Without this, nodes are generated with only hostName and the resulting
IP is unpredictable.
Extends the pattern already present in nfv-ovs-dpdk-sriov-hci to:
ovs-dpdk, ovs-dpdk-sriov, sriov, nfv-ovs-dpdk-sriov-2nodesets,
and nfv-ovs-dpdk-sriov-networker.
Signed-off-by: Miguel Angel Nieto Jimenez mnietoji@redhat.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com