Skip to content

Add per-node config (ansibleHost, networks, fixedIP) to all NFV scena…#756

Open
mnietoji wants to merge 1 commit into
openstack-k8s-operators:mainfrom
mnietoji:fix/nfv-nodes-config
Open

Add per-node config (ansibleHost, networks, fixedIP) to all NFV scena…#756
mnietoji wants to merge 1 commit into
openstack-k8s-operators:mainfrom
mnietoji:fix/nfv-nodes-config

Conversation

@mnietoji
Copy link
Copy Markdown
Contributor

@mnietoji mnietoji commented May 10, 2026

Add per-node config (ansibleHost, networks, fixedIP) to all NFV scenarios
Define per-node networks with fixedIP in all NFV nodeset values so that
each compute node gets a known IP address on the ctlplane network.
Without this, nodes are generated with only hostName and the resulting
IP is unpredictable.

Extends the pattern already present in nfv-ovs-dpdk-sriov-hci to:
ovs-dpdk, ovs-dpdk-sriov, sriov, nfv-ovs-dpdk-sriov-2nodesets,
and nfv-ovs-dpdk-sriov-networker.

Signed-off-by: Miguel Angel Nieto Jimenez mnietoji@redhat.com
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

@openshift-ci openshift-ci Bot requested review from abays and fultonj May 10, 2026 19:25
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mnietoji
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mnietoji mnietoji force-pushed the fix/nfv-nodes-config branch 2 times, most recently from 013e158 to 4530e73 Compare May 10, 2026 19:39
@mnietoji mnietoji added the ready-review Request is ready to be reviewed label May 13, 2026
@mnietoji
Copy link
Copy Markdown
Contributor Author

@abays @fultonj can you review this PR?
Thanks!!

@fultonj fultonj requested a review from Jaganathancse May 15, 2026 21:13
@fultonj
Copy link
Copy Markdown
Contributor

fultonj commented May 15, 2026

The generated output looks mostly correct. E.g. if I look at the nfv-ovs-dpdk-sriov-2nodesets scenario, I see the extra networks.

[johfulto@laptop architecture{fix/nfv-nodes-config}]$ diff -u /tmp/cr-review/nfv/2nodesets-ns1-before.yaml /tmp/cr-review/nfv/2nodesets-ns1-after.yaml
--- /tmp/cr-review/nfv/2nodesets-ns1-before.yaml        2026-05-15 17:14:14.581082125 -0400
+++ /tmp/cr-review/nfv/2nodesets-ns1-after.yaml 2026-05-15 17:14:14.723085230 -0400
@@ -224,7 +224,20 @@
       subnetName: subnet1
   nodes:
     edpm-compute-0:
+      ansible:
+        ansibleHost: 192.168.122.100
       hostName: edpm-compute-0
+      networks:
+      - defaultRoute: true
+        fixedIP: 192.168.122.100
+        name: ctlplane
+        subnetName: subnet1
+      - name: internalapi
+        subnetName: subnet1
+      - name: storage
+        subnetName: subnet1
+      - name: tenant
+        subnetName: subnet1
   preProvisioned: false
   services:
   - bootstrap
[johfulto@laptop architecture{fix/nfv-nodes-config}]$ 

OR

[johfulto@laptop architecture{fix/nfv-nodes-config}]$ diff -u /tmp/cr-review/nfv/2nodesets-ns2-before.yaml /tmp/cr-review/nfv/2nodesets-ns2-after.yaml
--- /tmp/cr-review/nfv/2nodesets-ns2-before.yaml        2026-05-15 17:14:14.651083656 -0400
+++ /tmp/cr-review/nfv/2nodesets-ns2-after.yaml 2026-05-15 17:14:14.800086914 -0400
@@ -224,7 +224,20 @@
       subnetName: subnet1
   nodes:
     edpm-compute-1:
+      ansible:
+        ansibleHost: 192.168.122.101
       hostName: edpm-compute-1
+      networks:
+      - defaultRoute: true
+        fixedIP: 192.168.122.101
+        name: ctlplane
+        subnetName: subnet1
+      - name: internalapi
+        subnetName: subnet1
+      - name: storage
+        subnetName: subnet1
+      - name: tenant
+        subnetName: subnet1
   preProvisioned: false
   services:
   - bootstrap
[johfulto@laptop architecture{fix/nfv-nodes-config}]$ 

@fultonj
Copy link
Copy Markdown
Contributor

fultonj commented May 15, 2026

Should we get someone else form the NFV team to review before merging?

Copy link
Copy Markdown
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnietoji Thanks for this.

Is there a duplicate below that should be fixed?

Comment thread examples/dt/nfv/nfv-ovs-dpdk-sriov-networker/edpm/networkers/values.yaml Outdated
@abays
Copy link
Copy Markdown
Contributor

abays commented May 18, 2026

I agree with @fultonj's comments, but otherwise LGTM

…rios

Define per-node networks with fixedIP in all NFV nodeset values so that
each compute node gets a known IP address on the ctlplane network.
Without this, nodes are generated with only hostName and the resulting
IP is unpredictable.

Extends the pattern already present in nfv-ovs-dpdk-sriov-hci to:
ovs-dpdk, ovs-dpdk-sriov, sriov, nfv-ovs-dpdk-sriov-2nodesets,
and nfv-ovs-dpdk-sriov-networker.

Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@mnietoji mnietoji force-pushed the fix/nfv-nodes-config branch from 4530e73 to 50c992b Compare May 19, 2026 14:41
@mnietoji
Copy link
Copy Markdown
Contributor Author

@fultonj @Jaganathancse @abays @sfitzger
can you review? i updated it according to latest comments and tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-review Request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants