Conversation
57912c6 to
55539c5
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7722c30130f04cd09027a0b3923bf965 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7107ca6b6b9463abb5f2e6a1502b487 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e80052b9e68442a1bc0f660dfab2f580 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2b22395d6dcb4815b5a96d9bf4ea949f ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f23489c0613b4c5e99b5b475942ddecb ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bfaeb55987b540058763ff4030f3d2e0 ✔️ noop SUCCESS in 0s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b87d1836b34846cfa9469f80cb3c9327 ✔️ noop SUCCESS in 0s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0de17485fe724363b91a0ed36ca28816 ✔️ noop SUCCESS in 0s |
| # Allow src_file paths to traverse outside the stage path | ||
| _path = (source / f).resolve() |
There was a problem hiding this comment.
@fultonj What do you think about this? See https://github.com/openstack-k8s-operators/architecture/pull/693/changes#diff-4f3f430f947b93ad5cc30274ea06d33908e6c1af52012f9955e60f2429cd6550R86 to see how it's used.
There was a problem hiding this comment.
Approving this sets precedence that .. traversal in src_file is an acceptable pattern.
I think that's OK. I think it's good to promote DRY instead of requiring the same files to be copied (avoid drift).
An alternative is to do a symlink, but I think that would make things more messy. Let's just be clear that there will be cases where from other VAs/DTs could be used.
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#3684 is needed. |
fultonj
left a comment
There was a problem hiding this comment.
This looks like a good VA and a bulk of the work is done. I'd like to request some markdown files however.
There's no markdown files in this PR explaining what it is and what it does.
Please add them. Use this as an example:
https://github.com/openstack-k8s-operators/architecture/blob/main/examples/va/hci/README.md
Anyone should be able to clone this repo and use kustomize to build the example CRs by following the read README files. We shouldn't require people to read automation/vars/multi-namespace-skmo.yaml
| # Allow src_file paths to traverse outside the stage path | ||
| _path = (source / f).resolve() |
There was a problem hiding this comment.
Approving this sets precedence that .. traversal in src_file is an acceptable pattern.
I think that's OK. I think it's good to promote DRY instead of requiring the same files to be copied (avoid drift).
An alternative is to do a symlink, but I think that would make things more messy. Let's just be clear that there will be cases where from other VAs/DTs could be used.
Configure the multi-namespace SKMO scenario with: - SKMO-specific control-plane kustomization for the central region with barbican-keystone-listener pool_name and RabbitMQ memory reduction (4Gi -> 2Gi) for compact clusters - Barbican keystone listener pool_name configuration for both central (regionOne) and leaf (regionTwo) regions - Automation stages updated to reference SKMO-specific paths - Post-stage hooks for cross-region CA trust, transport URL setup, and barbican-keystone-listener configuration - Wait conditions adjusted for parallel deployment - Correct keystone endpoint values for leaf region - CA trust configuration between central and leaf regions - Symlink net-env for SKMO to reuse multi-namespace networking - README documenting the SKMO scenario and deployment stages Depends-On: openstack-k8s-operators/ci-framework#3684 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Ade Lee <alee@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vakwetu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#3684 is needed. |
|
comments addressed. added wip till testing is complete |
|
recheck |
|
This PR was superseded by #716 |
Add multi-namespace SKMO support
Configure the multi-namespace SKMO scenario with:
with barbican-keystone-listener pool_name and RabbitMQ memory
reduction (4Gi -> 2Gi) for compact clusters
central (regionOne) and leaf (regionTwo) regions
Depends-On: openstack-k8s-operators/ci-framework#3684