[WIP] OCPMCP-308: Add mcpchecker JUnit suite to Sippy allowlist

[cajieh]

Summary

• Allowlists the mcpchecker JUnit suite name in pkg/db/suites.go so Sippy can ingest task pass/fail results from mcpchecker Prow jobs (OCPMCP-108).
• Adds unit tests to verify the mcpchecker suite is importable.
• Includes a spike plan doc (docs/plans/ocpmcp-308-eval-dashboard-sippy-spike.md) documenting scope, what this change does and does not cover, and companion work needed for the full eval dashboard.

Test plan

• go test ./pkg/db/ -run TestIsSuiteImportable passes
• make test passes
• Verify mcpchecker JUnit XML (with testsuite name="mcpchecker") would be accepted by the suite allowlist

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added support for importing mcpchecker test results into Sippy.
  • Documented expected result-import behavior, validation steps, and scope for future evaluation dashboard work.

• Tests

  • Added coverage confirming supported and unknown test suite names are handled correctly.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

Sippy now allows mcpchecker JUnit results for import. Tests cover known and unknown suite names. A spike plan documents ingestion scope, unsupported dashboard capabilities, companion configuration work, and local validation commands.

Changes

mcpchecker import support

Layer / File(s)	Summary
mcpchecker allowlist and validation pkg/db/suites.go, pkg/db/suites_test.go, docs/plans/ocpmcp-308-eval-dashboard-sippy-spike.md	The suite allowlist accepts mcpchecker. Tests verify known and unknown suite handling. The spike plan documents supported ingestion and dashboard scope.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 21

✅ Passed checks (21 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	The PR adds only a suite string, comments, and boolean unit tests. It introduces no ignored errors, panic calls, pointer dereferences, or new error-returning code.
Sql Injection Prevention	✅ Passed	The PR adds only the literal "mcpchecker" suite name and tests. The existing suite lookup uses GORM placeholders (name = ?); no SQL construction or concatenation was added.
Excessive Css In React Should Use Styles	✅ Passed	The PR changes only Go and Markdown files; it adds no React components or inline CSS requiring the useStyles pattern.
Test Coverage For New Features	✅ Passed	The new mcpchecker allowlist entry is covered by TestIsSuiteImportableMcpchecker, with additional known and unknown suite checks.
Single Responsibility And Clear Naming	✅ Passed	The PR adds one precise mcpchecker suite entry, focused tests, and documentation. It adds no package, struct, or method, and IsSuiteImportable remains focused.
Feature Documentation	✅ Passed	The change is a narrow JUnit suite allowlist, not a change to the documented symptoms feature; the new spike plan documents mcpchecker scope, ingestion, and limitations.
Stable And Deterministic Test Names	✅ Passed	The PR adds only standard Go tests with static names; no Ginkgo It/Describe/Context titles or dynamic test-name construction appears in the diff.
Test Structure And Quality	✅ Passed	The PR adds standard Go tests using testing.T, not Ginkgo tests; no cluster resources, waits, or Ginkgo assertions require review under this check.
Microshift Test Compatibility	✅ Passed	The PR changes only a suite allowlist, unit tests, and documentation; it adds no Ginkgo e2e tests or MicroShift-sensitive test APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR adds only standard Go unit tests and documentation; it adds no Ginkgo e2e tests or multi-node assumptions requiring SNO review.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only suite allowlisting, unit tests, and documentation; it adds no deployment, operator, controller, manifest, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only Sippy suite allowlisting, unit tests, and documentation; no OTE binary or process-level stdout/logging code is added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR adds only a suite allowlist, unit tests, and documentation. It adds no Ginkgo e2e tests or IPv4/external-connectivity behavior.
No-Weak-Crypto	✅ Passed	The PR adds only an allowlist string, documentation, and suite tests. Added-line and AST searches found no weak crypto APIs, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The patch changes only Markdown and Go files. No container/Kubernetes manifests or privilege indicators were added.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds one suite constant, tests, and documentation. It adds no logging calls or sensitive values; existing logs only emit suite names and unchanged database errors.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: adding the mcpchecker JUnit suite to the Sippy allowlist.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cajieh
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@cajieh: This pull request references OCPMCP-308 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

• Allowlists the mcpchecker JUnit suite name in pkg/db/suites.go so Sippy can ingest task pass/fail results from mcpchecker Prow jobs (OCPMCP-108).
• Adds unit tests to verify the mcpchecker suite is importable.
• Includes a spike plan doc (docs/plans/ocpmcp-308-eval-dashboard-sippy-spike.md) documenting scope, what this change does and does not cover, and companion work needed for the full eval dashboard.

Test plan

• go test ./pkg/db/ -run TestIsSuiteImportable passes
• make test passes
• Verify mcpchecker JUnit XML (with testsuite name="mcpchecker") would be accepted by the suite allowlist

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

• Added support for importing mcpchecker test results into Sippy.

• Documented expected result-import behavior, validation steps, and scope for future evaluation dashboard work.

• Tests

• Added coverage confirming supported and unknown test suite names are handled correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci]

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.