Skip to content

Add OSD GCP operator e2e and HyperShift CI to ROSA releases - #3860

Open
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:feat/add-gcp-operator-sippy
Open

Add OSD GCP operator e2e and HyperShift CI to ROSA releases#3860
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:feat/add-gcp-operator-sippy

Conversation

@dustman9000

@dustman9000 dustman9000 commented Aug 1, 2026

Copy link
Copy Markdown
Member

Summary

Update rosa-stage and rosa-integration release regexps to capture new Prow jobs:

  • OSD GCP operator e2e: osd-gcp-e2e-promotion-int/stage for RMO, CAMO, MUO, OAO, SFO (5 operators)
  • AVO branch fix: AVO uses main not master, was excluded from the -master- regex
  • HyperShift CI: New sector tests for integration and staging

Changes the operator e2e regexps from:

^periodic-ci-openshift-.*-master-rosa-sts-e2e-promotion-(int|stage)$

to:

^periodic-ci-openshift-.*-(master|main)-(rosa-sts|osd-gcp)-e2e-promotion-(int|stage)$

Summary by CodeRabbit

  • Tests
    • Expanded automated validation coverage for ROSA staging and integration workflows.
    • Added support for SRE operator end-to-end checks across supported branches and environments.
    • Added HyperShift CI sector test coverage for staging and integration scenarios.
    • Updated existing validation patterns to reflect current test configurations.

…stage/int

Update ROSA release regexps to capture:
- OSD GCP operator e2e promotion jobs (osd-gcp-e2e-promotion-*)
- AVO which uses main branch instead of master
- HyperShift CI sector tests (integration + staging)
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cd3d2b5c-5660-4d72-97cb-a0e2fee1ebe1

📥 Commits

Reviewing files that changed from the base of the PR and between f66444a and 20313de.

📒 Files selected for processing (1)
  • config/openshift-customizations.yaml

Walkthrough

Changes

ROSA presubmit pattern updates

Layer / File(s) Summary
Update stage and integration regex coverage
config/openshift-customizations.yaml
The ROSA stage and integration regexes now match SRE operator tests from master and main across STS and GCP. They also include HyperShift CI staging and integration tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: radekcap, ravitri

🚥 Pre-merge checks | ✅ 21
✅ Passed checks (21 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main changes: OSD GCP operator e2e and HyperShift CI support for ROSA releases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Go Error Handling ✅ Passed The pull request changes only config/openshift-customizations.yaml; no Go files or Go error-handling code are changed.
Sql Injection Prevention ✅ Passed The PR changes only regex strings and comments in config/openshift-customizations.yaml; it adds no SQL queries, database calls, or user-input query construction.
Excessive Css In React Should Use Styles ✅ Passed The pull request changes only config/openshift-customizations.yaml. It adds no React components or inline CSS objects, so this check is not applicable.
Test Coverage For New Features ✅ Passed The PR changes only config/openshift-customizations.yaml; the check explicitly excludes configuration-only changes from test coverage requirements.
Single Responsibility And Clear Naming ✅ Passed The PR only updates two clearly scoped YAML regex lists; release names and comments distinguish ROSA stage/integration, SRE operator, and HyperShift tests, with no generic entities added.
Feature Documentation ✅ Passed The commit changes only ROSA release regexes; no relevant feature document exists, and the change does not alter documented data models, data flow, APIs, or core concepts.
Stable And Deterministic Test Names ✅ Passed The commit changes only static regexes in config/openshift-customizations.yaml; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The PR changes only config/openshift-customizations.yaml; no Ginkgo test code or test files changed, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed The PR changes only config/openshift-customizations.yaml regexes; it adds no Ginkgo e2e tests or test references to MicroShift-incompatible APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only config/openshift-customizations.yaml; no new Go files or Ginkgo It/Describe/Context/When tests were added.
Topology-Aware Scheduling Compatibility ✅ Passed The patch changes only regex entries in config/openshift-customizations.yaml; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only config/openshift-customizations.yaml regexes; repository searches found no OTE binary or suite setup changed by this PR.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only config/openshift-customizations.yaml regexes and adds no Ginkgo e2e tests, so IPv6 or disconnected-test compatibility review is not applicable.
No-Weak-Crypto ✅ Passed The pull request changes only regexes and comments in config/openshift-customizations.yaml; no weak-crypto or custom crypto usage is introduced.
Container-Privileges ✅ Passed The only changed file adds release regexes in config/openshift-customizations.yaml; the patch adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only Prow job regexes and comments in YAML; it adds no logging code or sensitive values such as passwords, tokens, API keys, PII, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from deepsm007 and neisw August 1, 2026 19:38
@openshift-ci

openshift-ci Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dustman9000
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 1, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-ci

openshift-ci Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant