Skip to content

NE-2216: parameterize haproxy version#733

Open
jcmoraisjr wants to merge 1 commit intoopenshift:masterfrom
jcmoraisjr:NE-2216-param-haproxy-version
Open

NE-2216: parameterize haproxy version#733
jcmoraisjr wants to merge 1 commit intoopenshift:masterfrom
jcmoraisjr:NE-2216-param-haproxy-version

Conversation

@jcmoraisjr
Copy link
Member

add two new envvars used to parameterize how to start or reload haproxy.

  • ROUTER_HAPROXY_VERSION: defines the haproxy version to use. I must be one of the installed versions. If missing, it defaults to not use any suffix, preserving the same behavior before the change.

  • ROUTER_HAPROXY_MASTER_UNIX_SOCKET: defines the full qualified path of master's unix socket. If provided, a reload command is issued to master instead of using the reload script, so configuring this option makes ROUTER_HAPROXY_VERSION to be ignored. If missing, the previous behavior is used, which is to call the reload script.

add two new envvars used to parameterize how to start or reload haproxy.

* ROUTER_HAPROXY_VERSION: defines the haproxy version to use. I must be
  one of the installed versions. If missing, it defaults to not use any
  suffix, preserving the same behavior before the change.

* ROUTER_HAPROXY_MASTER_UNIX_SOCKET: defines the full qualified path of
  master's unix socket. If provided, a reload command is issued to
  master instead of using the reload script, so configuring this option
  makes ROUTER_HAPROXY_VERSION to be ignored. If missing, the previous
  behavior is used, which is to call the reload script.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2026

@jcmoraisjr: This pull request references NE-2216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

add two new envvars used to parameterize how to start or reload haproxy.

  • ROUTER_HAPROXY_VERSION: defines the haproxy version to use. I must be one of the installed versions. If missing, it defaults to not use any suffix, preserving the same behavior before the change.

  • ROUTER_HAPROXY_MASTER_UNIX_SOCKET: defines the full qualified path of master's unix socket. If provided, a reload command is issued to master instead of using the reload script, so configuring this option makes ROUTER_HAPROXY_VERSION to be ignored. If missing, the previous behavior is used, which is to call the reload script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from candita and frobware February 13, 2026 17:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign alebedev87 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2026

@jcmoraisjr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants