NO-JIRA: Do not install weak dependencies such as logrotate#687
Conversation
When installing the haproxy-router image's package dependencies, specify --setopt=install_weak_deps=0 to avoid install weak dependencies. In particular, this commit avoids installing the rsyslog-logrotate package, which is a weak dependency of the rsyslog package. The rsyslog-logrotate package requires the logrotate package; the router does not need either of these packages. Installing these unnecessary packages enlarges the size and attack surface of the container image. * hack/Dockerfile.debug: * images/router/haproxy/Dockerfile: * images/router/haproxy/Dockerfile.ocp: * images/router/haproxy/Dockerfile.rhel: Specify the --setopt=install_weak_deps=0 option for yum install.
|
/assign |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
Bot
removed
the
lifecycle/stale
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@alebedev87: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retitle NO-JIRA: Do not install weak dependencies such as logrotate |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@Miciah: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
When installing the haproxy-router image's package dependencies, specify
--setopt=install_weak_deps=0to avoid install weak dependencies.In particular, this change avoids installing the rsyslog-logrotate package, which is a weak dependency of the rsyslog package. The rsyslog-logrotate package requires the logrotate package; the router does not need either of these packages. Installing these unnecessary packages enlarges the size and attack surface of the container image.