OCM-18900 | fix: Improve proxy validation error messages for special characters in passwords by olucasfreitas · Pull Request #3052 · openshift/rosa

olucasfreitas · 2025-10-21T13:18:42Z

Details

This PR fixes a usability issue where rosa create cluster --http-proxy was displaying unhelpful error messages when proxy passwords contained special characters like forward slashes, making it difficult for users to understand what was wrong with their input.

Problem (Before)

rosa create cluster --http-proxy "http://proxyuser:QvoZjyy/trkCiY5@10.0.0.161:8080"

Output:

E: Invalid http-proxy value 'http://proxyuser:QvoZjyy/trkCiY5@10.0.0.161:8080'

The user has no idea what's wrong with the URL.

Fixed Behavior (After)

./rosa create cluster --http-proxy "http://proxyuser:QvoZjyy/trkCiY5@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: password contains invalid character '/'

Now the user knows exactly what's wrong.

Additional Validations

The implementation validates special characters in both username and password fields:

Forward slash in password:

rosa edit cluster --cluster=my-cluster --http-proxy "http://user:pass/word@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: password contains invalid character '/'

@ symbol in password:

rosa edit cluster --cluster=my-cluster --http-proxy "http://user:p@ssword@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: password contains invalid character '@'

Question mark in password:

rosa edit cluster --cluster=my-cluster --http-proxy "http://user:pass?word@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: password contains invalid character '?'

Hash in password:

rosa edit cluster --cluster=my-cluster --http-proxy "http://user:pass#word@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: password contains invalid character '#'

Invalid character in username:

rosa edit cluster --cluster=my-cluster --http-proxy "http://us/er:password@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: username contains invalid character '/'

Missing scheme:

rosa edit cluster --cluster=my-cluster --http-proxy "user:password@10.0.0.161:8080"

Output:

ERR: invalid http-proxy value: URL is missing scheme (expected '://')

HTTPS proxy validation:

rosa edit cluster --cluster=my-cluster --https-proxy "https://user:pass/word@10.0.0.161:8080"

Output:

ERR: invalid https-proxy value: password contains invalid character '/'

Ticket

Closes OCM-18900

codecov · 2025-10-21T13:54:05Z

Codecov Report

❌ Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.08%. Comparing base (c854a37) to head (dde1c46).
⚠️ Report is 107 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/ocm/helpers.go	87.87%	3 Missing and 1 partial ⚠️
cmd/create/cluster/cmd.go	0.00%	1 Missing ⚠️
cmd/edit/cluster/cmd.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3052      +/-   ##
==========================================
+ Coverage   23.91%   24.08%   +0.17%     
==========================================
  Files         317      330      +13     
  Lines       35202    35941     +739     
==========================================
+ Hits         8418     8657     +239     
- Misses      26143    26631     +488     
- Partials      641      653      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

olucasfreitas · 2025-11-03T11:37:00Z

/retest-required

olucasfreitas · 2025-11-03T15:15:52Z

/retest-required

olucasfreitas · 2025-11-03T15:22:59Z

/retest-required

hunterkepley

The test case in the bug ticket does not seem to pass:

E: parse "http://proxyuser:QvoZjyy/trkCiY5@10.0.0.161:8080": invalid port ":QvoZjyy" after host

I think there may be a bug in the parse code

olucasfreitas · 2025-11-03T15:58:28Z

@hunterkepley I just did some tests here, and it seems to be working after the fix, did you test it with the branch locally ?

olucasfreitas · 2025-11-04T11:08:34Z

/retest-required

olucasfreitas · 2025-11-04T11:16:05Z

/retest-required

hunterkepley · 2025-11-19T14:35:39Z

/test e2e-presubmits-pr-rosa-hcp-advanced

hunterkepley · 2025-11-19T14:35:45Z

/test e2e-presubmits-pr-rosa-sts-advanced

openshift-ci · 2025-11-19T20:05:45Z

@olucasfreitas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/coverage	`2637639`	link	true	`/test coverage`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

olucasfreitas · 2025-11-19T20:22:04Z

/retest

hunterkepley

could we provide a copyright notice in the brand new file(s)?

…al characters

olucasfreitas · 2026-02-18T23:09:09Z

/retest

marcolan018 · 2026-02-24T15:04:41Z

/lgtm

openshift-ci · 2026-02-24T15:08:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcolan018, olucasfreitas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [marcolan018]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot requested review from ciaranRoche and hunterkepley October 21, 2025 13:19

gdbranco reviewed Oct 21, 2025

View reviewed changes

Comment thread pkg/ocm/helpers_test.go

olucasfreitas force-pushed the OCM-18900 branch from fc09c54 to aa528ca Compare October 21, 2025 15:11

olucasfreitas requested a review from gdbranco October 21, 2025 17:03

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025

gdbranco reviewed Oct 28, 2025

View reviewed changes

Comment thread cmd/list/dnsdomains/cmd.go Outdated

olucasfreitas force-pushed the OCM-18900 branch 2 times, most recently from 00638f4 to 120a803 Compare November 3, 2025 11:36

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2025

olucasfreitas requested a review from gdbranco November 3, 2025 11:36

hunterkepley reviewed Nov 3, 2025

View reviewed changes

Comment thread cmd/list/dnsdomains/cmd.go Outdated

hunterkepley reviewed Nov 3, 2025

View reviewed changes

Comment thread tests/utils/exec/rosacli/upgrade_service.go

hunterkepley reviewed Nov 3, 2025

View reviewed changes

Comment thread pkg/ocm/helpers.go Outdated

olucasfreitas force-pushed the OCM-18900 branch 2 times, most recently from 2260456 to c6b94b4 Compare November 3, 2025 14:46

olucasfreitas requested a review from hunterkepley November 3, 2025 15:16

hunterkepley reviewed Nov 3, 2025

View reviewed changes

olucasfreitas force-pushed the OCM-18900 branch 2 times, most recently from 96029c9 to a50904c Compare November 3, 2025 19:49

hunterkepley reviewed Nov 4, 2025

View reviewed changes

Comment thread tests/e2e/test_rosacli_cluster.go

Comment thread pkg/ocm/helpers_test.go Outdated

Comment thread pkg/ocm/helpers.go Outdated

Comment thread pkg/ocm/helpers.go Outdated

Comment thread pkg/ocm/helpers.go Outdated

Comment thread pkg/ocm/helpers.go Outdated

olucasfreitas force-pushed the OCM-18900 branch 2 times, most recently from 9502aa4 to 2637639 Compare November 5, 2025 15:38

olucasfreitas force-pushed the OCM-18900 branch 2 times, most recently from 34c6edf to 875a547 Compare November 19, 2025 19:47

olucasfreitas force-pushed the OCM-18900 branch from 875a547 to 4fe55d7 Compare November 19, 2025 20:37

olucasfreitas requested a review from hunterkepley November 19, 2025 21:11

olucasfreitas force-pushed the OCM-18900 branch from 4fe55d7 to a51e1b8 Compare December 1, 2025 17:17

hunterkepley reviewed Dec 2, 2025

View reviewed changes

olucasfreitas force-pushed the OCM-18900 branch 2 times, most recently from f7318dc to 3d09b7b Compare December 8, 2025 15:43

hunterkepley reviewed Dec 8, 2025

View reviewed changes

Comment thread pkg/ocm/helpers.go Outdated

Comment thread pkg/ocm/helpers.go Outdated

Comment thread pkg/ocm/helpers.go Outdated

Comment thread pkg/helper/url/validation.go Outdated

Comment thread pkg/helper/url/validation.go Outdated

olucasfreitas force-pushed the OCM-18900 branch from 3d09b7b to 770854f Compare December 9, 2025 20:03

olucasfreitas requested a review from hunterkepley January 20, 2026 15:29

hunterkepley reviewed Jan 21, 2026

View reviewed changes

Comment thread pkg/helper/url/validation.go Outdated

Comment thread pkg/helper/url/validation.go Outdated

Comment thread pkg/interactive/validation_test.go

Comment thread pkg/ocm/helpers.go Outdated

olucasfreitas force-pushed the OCM-18900 branch from 770854f to 48eb409 Compare January 27, 2026 17:43

hunterkepley reviewed Feb 12, 2026

View reviewed changes

olucasfreitas force-pushed the OCM-18900 branch from 48eb409 to c4925eb Compare February 16, 2026 15:58

OCM-18900 | fix: Improve error message for proxy passwords with speci…

dde1c46

…al characters

olucasfreitas force-pushed the OCM-18900 branch from c4925eb to dde1c46 Compare February 18, 2026 17:27

marcolan018 reviewed Feb 24, 2026

View reviewed changes

Comment thread pkg/helper/url/validation.go

openshift-ci Bot assigned marcolan018 Feb 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2026

openshift-merge-bot Bot merged commit 092e2de into openshift:master Feb 24, 2026
14 checks passed

Conversation

olucasfreitas commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Problem (Before)

Fixed Behavior (After)

Additional Validations

Ticket

Uh oh!

Uh oh!

codecov Bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

olucasfreitas commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olucasfreitas commented Nov 3, 2025

Uh oh!

olucasfreitas commented Nov 3, 2025

Uh oh!

hunterkepley left a comment

Choose a reason for hiding this comment

Uh oh!

olucasfreitas commented Nov 3, 2025

Uh oh!

olucasfreitas commented Nov 4, 2025

Uh oh!

olucasfreitas commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hunterkepley commented Nov 19, 2025

Uh oh!

hunterkepley commented Nov 19, 2025

Uh oh!

openshift-ci Bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

olucasfreitas commented Nov 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hunterkepley left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

olucasfreitas commented Feb 18, 2026

Uh oh!

olucasfreitas commented Oct 21, 2025 •

edited

Loading

codecov Bot commented Oct 21, 2025 •

edited

Loading

openshift-ci Bot commented Nov 19, 2025 •

edited

Loading

hunterkepley left a comment •

edited

Loading