Skip to content

Add GCP and Azure variants of tls-scanner TLSAdherence jobs - #83196

Open
richardsonnick wants to merge 1 commit into
openshift:mainfrom
richardsonnick:add-tls-adherence-platform-variants
Open

Add GCP and Azure variants of tls-scanner TLSAdherence jobs#83196
richardsonnick wants to merge 1 commit into
openshift:mainfrom
richardsonnick:add-tls-adherence-platform-variants

Conversation

@richardsonnick

@richardsonnick richardsonnick commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Adds GCP and Azure TLS 1.3 adherence jobs to the tls-scanner OpenShift CI configuration.

  • Adds periodic jobs for the main branch that run every 72 hours.
  • Adds optional jobs for releases 4.23, 5.0, and 5.1.
  • Configures platform-specific cluster profiles, compute node types, and OVN workflows.
  • Enables strict TLS adherence checks and TLS scanner tests.
  • Disables PQC checks where required.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsonnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Added GCP and Azure TLS 1.3 adherence coverage to periodic main jobs and optional OpenShift release tests. The configurations use cloud-specific profiles, compute types, strict adherence settings, scanner tests, and provider workflows.

Changes

TLS 1.3 adherence jobs

Layer / File(s) Summary
Periodic cloud adherence jobs
ci-operator/config/openshift/tls-scanner/openshift-tls-scanner-main.yaml
Added 72-hour GCP and Azure periodic jobs with provider-specific cluster profiles, compute node types, strict TLS 1.3 settings, and tls-13 plus tls-scanner-run tests.
Release cloud adherence tests
ci-operator/config/openshift/tls-scanner/openshift-tls-scanner-release-4.23.yaml, ci-operator/config/openshift/tls-scanner/openshift-tls-scanner-release-5.0.yaml, ci-operator/config/openshift/tls-scanner/openshift-tls-scanner-release-5.1.yaml
Added optional GCP and Azure tests with cloud-specific profiles, compute types, TLS adherence settings, scanner tests, and OVN workflows.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Container-Privileges ❌ Error Added GCP/Azure jobs invoke tls-scanner-run; its default path generates a Pod with privileged:true, hostNetwork:true, hostPID:true, and runAsUser:0. Use a non-privileged scanner mode for these jobs, or remove the new scanner references and obtain an explicit security exception for required host access.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only CI YAML and generated job definitions; all added job/ref names are static, and no Ginkgo It, Describe, Context, or When titles are introduced.
Test Structure And Quality ✅ Passed The PR changes only eight YAML CI configuration/job files; it adds no Go files, Ginkgo constructs, It blocks, or cluster-test implementation code to review.
Microshift Test Compatibility ✅ Passed The commit changes only YAML CI configuration and job files; it adds no Ginkgo test declarations or test source, and only references existing tls-13 and tls-scanner-run tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only CI YAML and generated job YAML, adds no Ginkgo It/Describe/Context/When tests, and introduces no SNO-relevant test assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The patch changes only ci-operator test definitions and generated Prow jobs. Added fields select cloud profiles, compute types, tests, and workflows; no workload scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed The pull request changes only CI YAML and generated Prow job YAML; it adds no OTE binary source or process-level stdout/logging code to assess.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only CI configuration YAML files without new Ginkgo e2e test code. The check applies to new test implementations (It, Describe, etc.), not CI job configurations.
No-Weak-Crypto ✅ Passed The PR adds only YAML job definitions; all 816 added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, crypto implementation, or secret comparison.
No-Sensitive-Data-In-Logs ✅ Passed The added YAML contains no credentials, PII, or sensitive literals; reporting posts only job state and a generic log URL, matching existing TLS scanner jobs.
Title check ✅ Passed The title clearly and concisely describes the added GCP and Azure TLSAdherence job variants.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@richardsonnick: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-tls-scanner-release-4.23-tls13-adherence-azure openshift/tls-scanner presubmit Presubmit changed
pull-ci-openshift-tls-scanner-release-4.23-tls13-adherence-gcp openshift/tls-scanner presubmit Presubmit changed
pull-ci-openshift-tls-scanner-release-5.0-tls13-adherence-azure openshift/tls-scanner presubmit Presubmit changed
pull-ci-openshift-tls-scanner-release-5.0-tls13-adherence-gcp openshift/tls-scanner presubmit Presubmit changed
pull-ci-openshift-tls-scanner-release-5.1-tls13-adherence-azure openshift/tls-scanner presubmit Presubmit changed
pull-ci-openshift-tls-scanner-release-5.1-tls13-adherence-gcp openshift/tls-scanner presubmit Presubmit changed
periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-azure N/A periodic Periodic changed
periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-gcp N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@richardsonnick

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@richardsonnick: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@richardsonnick

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-gcp

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@richardsonnick: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@richardsonnick
richardsonnick marked this pull request as ready for review August 10, 2026 19:43
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2026
@openshift-ci
openshift-ci Bot requested review from rhmdnd and smith-xyz August 10, 2026 19:44
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@richardsonnick: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-gcp 5cb5500 link unknown /pj-rehearse periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-gcp
ci/rehearse/periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-azure 5cb5500 link unknown /pj-rehearse periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence-azure
ci/rehearse/openshift/tls-scanner/release-4.23/tls13-adherence-gcp 5cb5500 link unknown /pj-rehearse pull-ci-openshift-tls-scanner-release-4.23-tls13-adherence-gcp
ci/rehearse/openshift/tls-scanner/release-5.0/tls13-adherence-azure 5cb5500 link unknown /pj-rehearse pull-ci-openshift-tls-scanner-release-5.0-tls13-adherence-azure
ci/rehearse/openshift/tls-scanner/release-4.23/tls13-adherence-azure 5cb5500 link unknown /pj-rehearse pull-ci-openshift-tls-scanner-release-4.23-tls13-adherence-azure

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant