step-registry/tls-scanner: fix deprecated variable fallback - #83145
step-registry/tls-scanner: fix deprecated variable fallback#83145machine424 wants to merge 1 commit into
Conversation
The split resource variables (SCANNER_CPU_REQUEST, etc.) had non-empty
defaults that shadowed the deprecated SCANNER_CPU/SCANNER_MEMORY values.
CI configs setting only the old names got the YAML defaults (4/4Gi)
instead of their intended values, causing pods to fail scheduling.
Clear the defaults so the shell fallback (${SCANNER_CPU_REQUEST:-${SCANNER_CPU}})
actually reaches the deprecated variables when the new ones aren't explicitly set.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: machine424 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WalkthroughTLS scanner resource request and limit environment defaults now use empty strings for management, guest, and standard scanner runs. Existing documentation and fallback variables remain unchanged. ChangesTLS scanner resource defaults
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
A total of 120 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws pull-ci-openshift-ptp-operator-main-e2e-aws pull-ci-openshift-cluster-storage-operator-main-tls-scanner-vsphere-problem-detector |
|
@machine424: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@machine424: job(s): pull-ci-openshift-ptp-operator-main-e2e-aws either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-tls-scanner-main-periodic-tls13-adherence periodic-ci-openshift-tls-scanner-main-periodic-default-tls periodic-ci-openshift-tls-scanner-main-periodic-pqc-readiness |
|
@machine424: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-vertical-pod-autoscaler-operator-main-e2e-aws-olm pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn pull-ci-openshift-cluster-autoscaler-operator-main-e2e-aws pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-olm |
|
@machine424: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-custom-metrics-autoscaler-operator-main-cma-e2e-aws-ovn |
|
@machine424: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@machine424: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
The split resource variables (SCANNER_CPU_REQUEST, etc.) had non-empty defaults that shadowed the deprecated SCANNER_CPU/SCANNER_MEMORY values. CI configs setting only the old names got the YAML defaults (4/4Gi) instead of their intended values, causing pods to fail scheduling.
Clear the defaults so the shell fallback (${SCANNER_CPU_REQUEST:-${SCANNER_CPU}}) actually reaches the deprecated variables when the new ones aren't explicitly set.
follow up of #82865
Summary by CodeRabbit
Updated TLS scanner CI configurations for standard and HyperShift runs. Split resource variables now default to empty values, so configurations that use deprecated
SCANNER_CPUandSCANNER_MEMORYvariables correctly trigger fallback behavior instead of receiving unintended 4 CPU and 4 GiB defaults. This reduces pod scheduling failures in affected CI jobs.