Skip to content

no-jira: add AWS STS dualstack e2e periodic tests for 5.0 and 5.1 - #83136

Open
tthvo wants to merge 1 commit into
openshift:mainfrom
tthvo:private-dualstack-aws
Open

no-jira: add AWS STS dualstack e2e periodic tests for 5.0 and 5.1#83136
tthvo wants to merge 1 commit into
openshift:mainfrom
tthvo:private-dualstack-aws

Conversation

@tthvo

@tthvo tthvo commented Aug 7, 2026

Copy link
Copy Markdown
Member

Copy 4 AWS dualstack private periodic tests from 4.22 to 5.0 and 5.1 amd64-nightly configs, promoting them from TechPreview to GA.

Tests added:

  • aws-ipi-disc-priv-sts-fips-dualstack-ipv4-f28-destructive
  • aws-ipi-disc-priv-sts-fips-dualstack-ipv6-mini-perm-f7
  • aws-ipi-https-proxy-sts-dualstack-ipv4-f28-destructive
  • aws-ipi-https-proxy-sts-dualstack-ipv6-mini-perm-f7

Summary by CodeRabbit

  • Adds four AWS STS dual-stack periodic tests to the 5.0 and 5.1 amd64-nightly CI configurations.
  • Covers disconnected private STS and HTTPS proxy STS scenarios for IPv4 and IPv6.
  • Promotes these tests from TechPreview to GA and includes destructive and minimal-permission variants.

Copy 4 AWS dualstack private periodic tests from 4.22 to 5.0 and 5.1
amd64-nightly configs, promoting them from TechPreview to GA.

Tests added:
- aws-ipi-disc-priv-sts-fips-dualstack-ipv4-f28-destructive
- aws-ipi-disc-priv-sts-fips-dualstack-ipv6-mini-perm-f7
- aws-ipi-https-proxy-sts-dualstack-ipv4-f28-destructive
- aws-ipi-https-proxy-sts-dualstack-ipv6-mini-perm-f7
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@tthvo: This pull request explicitly references no jira issue.

Details

In response to this:

Copy 4 AWS dualstack private periodic tests from 4.22 to 5.0 and 5.1 amd64-nightly configs, promoting them from TechPreview to GA.

Tests added:

  • aws-ipi-disc-priv-sts-fips-dualstack-ipv4-f28-destructive
  • aws-ipi-disc-priv-sts-fips-dualstack-ipv6-mini-perm-f7
  • aws-ipi-https-proxy-sts-dualstack-ipv4-f28-destructive
  • aws-ipi-https-proxy-sts-dualstack-ipv6-mini-perm-f7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2026
@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tthvo
Once this PR has been reviewed and has the lgtm label, please assign amoghrd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c1b76623-6d24-4124-8e5c-77ec6ff8d219

📥 Commits

Reviewing files that changed from the base of the PR and between 916113d and 37a8c61.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.1-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.1__amd64-nightly.yaml

Walkthrough

The release 5.0 and 5.1 nightly configurations add scheduled AWS STS jobs for dual-stack IPv4-primary and IPv6-primary testing. The jobs cover disconnected private and HTTPS proxy environments with destructive and minimal-permission variants.

Changes

AWS STS dual-stack testing

Layer / File(s) Summary
Disconnected private STS jobs
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml, ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.1__amd64-nightly.yaml
Adds scheduled destructive IPv4-primary and minimal-permission IPv6-primary dual-stack jobs with FIPS, disconnected filters, permissions, and STS workflows.
HTTPS proxy STS jobs
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yaml, ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.1__amd64-nightly.yaml
Adds scheduled destructive IPv4-primary and minimal-permission IPv6-primary dual-stack jobs with HTTPS proxy enablement, manifest extraction, IP-family settings, and STS workflows.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Suggested labels: approved

Suggested reviewers: mgencur, mhanss

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the addition of AWS STS dual-stack periodic tests for the 5.0 and 5.1 configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only YAML CI job metadata; added lines contain no Ginkgo title calls or dynamic values used in test titles.
Test Structure And Quality ✅ Passed The pull request changes only four YAML configuration/job files and adds no Ginkgo test code; the requested test-structure checks are not applicable.
Microshift Test Compatibility ✅ Passed The diff adds only CI configuration and periodic job YAML entries; it adds no Ginkgo It/Describe/Context/When tests requiring MicroShift API compatibility review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR adds only four YAML CI configuration files and no new Ginkgo declarations or test code, so the SNO test-compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only ci-operator test and generated Prow periodic-job YAML; it adds no deployment manifests, operator/controller code, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only four YAML configuration files; no OTE binary, main/suite setup code, or stdout-writing call appears in the diff.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only four YAML configuration/job files and adds no Ginkgo e2e test declarations or test source.
No-Weak-Crypto ✅ Passed The commit adds only YAML job and generated Prow configuration; added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR changes only scheduled CI configs and generated Prow jobs. Added lines contain no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, allowPrivilegeEscalation, securityContext, or root setti...
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only CI job YAML; no logging/output commands or literal credentials appear. Secret entries are mounted path/name references, and BASE_DOMAIN is configuration, not log output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jadhaj and sgoveas August 7, 2026 23:55
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@tthvo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-5.1-amd64-nightly-aws-ipi-disc-priv-sts-fips-dualstack-ipv4-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-aws-ipi-https-proxy-sts-dualstack-ipv6-mini-perm-f7 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.1-amd64-nightly-aws-ipi-https-proxy-sts-dualstack-ipv4-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.1-amd64-nightly-aws-ipi-disc-priv-sts-fips-dualstack-ipv6-mini-perm-f7 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.1-amd64-nightly-aws-ipi-https-proxy-sts-dualstack-ipv6-mini-perm-f7 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-aws-ipi-disc-priv-sts-fips-dualstack-ipv4-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-aws-ipi-https-proxy-sts-dualstack-ipv4-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-5.0-amd64-nightly-aws-ipi-disc-priv-sts-fips-dualstack-ipv6-mini-perm-f7 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@tthvo

tthvo commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

/test core-valid

@openshift-ci

openshift-ci Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@tthvo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants