Skip to content

OCPBUGS-88732: Add CCCMO disruptive OTE presubmit#81252

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RadekManak:cccmo-ote-disruptive-presubmit
Jun 30, 2026
Merged

OCPBUGS-88732: Add CCCMO disruptive OTE presubmit#81252
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
RadekManak:cccmo-ote-disruptive-presubmit

Conversation

@RadekManak

@RadekManak RadekManak commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a trigger-only AWS presubmit for openshift/ccm/operator/disruptive/serial
  • run the migrated CCCMO disruptive tests through openshift-e2e-test instead of the legacy QE/private regression chain
  • wire CI so the operator fix and the migrated regression tests can be rehearsed together before merge

Why OTE

  • the old regression coverage lived in openshift-tests-private, which /testwith cannot rebuild together with component PRs
  • moving the tests into CCCMO's OTE binary lets the component change and the regression tests travel together in the same PR and payload rehearsal flow

Related

Summary by CodeRabbit

This updates the OpenShift CI configuration for openshift/cluster-cloud-controller-manager-operator to support a trigger-only AWS presubmit for openshift/ccm/operator/disruptive/serial.

In practical terms, it migrates the CCCMO disruptive regression coverage onto openshift-e2e-test instead of the legacy QE/private regression path, so the operator change and its regression suite can be rehearsed together in the same PR and payload flow. The new job is marked non-always_run, making it run only when explicitly triggered, and the generated Prow job ordering is adjusted to stay aligned with the source config.

The change also mirrors the structure of the existing openshift/service-ca-operator OTE operator presubmit as the test-plan reference for this new AWS job.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@RadekManak: This pull request references Jira Issue OCPBUGS-88732, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • add a trigger-only AWS presubmit for openshift/ccm/operator/disruptive/serial
  • run the migrated CCCMO disruptive tests through openshift-e2e-test instead of the legacy QE/private regression chain
  • wire CI so the operator fix and the migrated regression tests can be rehearsed together before merge

Why OTE

  • the old regression coverage lived in openshift-tests-private, which /testwith cannot rebuild together with component PRs
  • moving the tests into CCCMO's OTE binary lets the component change and the regression tests travel together in the same PR and payload rehearsal flow

Test plan

  • compared the job shape with the existing openshift/service-ca-operator OTE operator presubmit
  • make ci-operator-prowgen WHAT=openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main.yaml (fails locally in this workspace because the cluster profile resolver is unavailable)
  • make checkconfig (fails locally in this workspace with a podman mount invalid argument on /release/core-services/prow/02_config)

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 30, 2026
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2026
@openshift-ci openshift-ci Bot requested review from mdbooth and racheljpg June 30, 2026 08:44
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5b5aeda6-bb61-4d3b-ba20-aaefc8d60c3c

📥 Commits

Reviewing files that changed from the base of the PR and between 844be7e and 848d772.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main.yaml

Walkthrough

Two optional e2e test jobs are added to the CCM operator CI config for the main branch: a QE regression job using the cucushift-installer-rehearse-aws-ipi workflow and an AWS operator serial disruptive job using the ipi-aws workflow.

CCM AWS CI Test Jobs

Layer / File(s) Summary
New regression and disruptive serial test entries
ci-operator/config/openshift/cluster-cloud-controller-manager-operator/openshift-cluster-cloud-controller-manager-operator-main.yaml
Adds an optional always-false CCM QE regression job (openshift-e2e-test-clusterinfra-qe-regression chain, cucushift-installer-rehearse-aws-ipi workflow) and an optional serial disruptive operator OTE job (openshift-e2e-test ref, ipi-aws workflow, TEST_SUITE=openshift/ccm/operator/disruptive/serial).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change by adding a CCCMO disruptive OTE presubmit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds static ci-operator job config; no Ginkgo It/Describe/Context/When titles were introduced, and the new TEST_SUITE/job names are deterministic.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML jobs; no Ginkgo test code or assertions were modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed PASS: This patch only changes ci-operator YAML; it adds no new Ginkgo test code or in-repo MicroShift-sensitive API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The new disruptive CCM suite only manipulates configmaps/status and shows no node/topology assumptions or SNO-specific skips.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI test jobs were added in a Prow config YAML; no deployment manifests, operator code, controllers, node selectors, affinity, or replica settings changed.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML changed; no main/init/TestMain/suite code was touched, so no stdout contract risk.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR only adds CI job wiring for existing suites; no new Ginkgo test code is added, and the new job blocks show no IPv4-only or external-network assumptions.
No-Weak-Crypto ✅ Passed PASS: The only changed file is a CI YAML adding test jobs; diff and file search show no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed Changed CI config only adds test entries; no privileged:true, hostPID/Network/IPC, SYS_ADMIN, runAsUser, or allowPrivilegeEscalation fields appear in the modified YAML.
No-Sensitive-Data-In-Logs ✅ Passed The change only adds CI job metadata; no logging code or commands emit passwords, tokens, PII, hostnames, or other sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 844be7e30cfd04e967a3fccddc359c94a525a41b due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@RadekManak RadekManak force-pushed the cccmo-ote-disruptive-presubmit branch from 848d772 to 06bdbcd Compare June 30, 2026 08:47
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2026
@RadekManak RadekManak force-pushed the cccmo-ote-disruptive-presubmit branch 4 times, most recently from f231fe4 to 25af032 Compare June 30, 2026 09:01
@RadekManak

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@RadekManak

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack
The rehearsal failure is also the expected one:

error: error converting to options: suite "openshift/ccm/operator/disruptive/serial" does not exist
That happens because the release PR rehearsal is testing the new job wiring without the CCCMO PR merged into the payload image. So the job exists in release, but the component image used by the rehearsal still does not contain the new OTE suite yet.

The new suite is here: openshift/cluster-cloud-controller-manager-operator#472

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 30, 2026
Add a trigger-only AWS presubmit for the migrated CCCMO disruptive OTE suite so the operator fix and its regression tests can be rehearsed together from the same flow.
@RadekManak RadekManak force-pushed the cccmo-ote-disruptive-presubmit branch from 25af032 to d993396 Compare June 30, 2026 13:59
@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 30, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@RadekManak: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ipi-ccm-operator-serial-disruptive-ote openshift/cluster-cloud-controller-manager-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@RadekManak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-operator-serial-disruptive-ote 25af032 link unknown /pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-operator-serial-disruptive-ote

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theobarberbany

Copy link
Copy Markdown
Contributor

/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-operator-serial-disruptive-ote

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@theobarberbany: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@theobarberbany

Copy link
Copy Markdown
Contributor

/lgtm
/approve

assuming rehearses work

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2026
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RadekManak, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@theobarberbany: job(s): pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-operator-serial-disruptive-ote either don't exist or were not found to be affected, and cannot be rehearsed

@RadekManak

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@RadekManak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 30, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 5486e70 into openshift:main Jun 30, 2026
16 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@RadekManak: Jira Issue OCPBUGS-88732: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-88732 has not been moved to the MODIFIED state.

Details

In response to this:

Summary

  • add a trigger-only AWS presubmit for openshift/ccm/operator/disruptive/serial
  • run the migrated CCCMO disruptive tests through openshift-e2e-test instead of the legacy QE/private regression chain
  • wire CI so the operator fix and the migrated regression tests can be rehearsed together before merge

Why OTE

  • the old regression coverage lived in openshift-tests-private, which /testwith cannot rebuild together with component PRs
  • moving the tests into CCCMO's OTE binary lets the component change and the regression tests travel together in the same PR and payload rehearsal flow

Related

Summary by CodeRabbit

This updates the OpenShift CI configuration for openshift/cluster-cloud-controller-manager-operator to support a trigger-only AWS presubmit for openshift/ccm/operator/disruptive/serial.

In practical terms, it migrates the CCCMO disruptive regression coverage onto openshift-e2e-test instead of the legacy QE/private regression path, so the operator change and its regression suite can be rehearsed together in the same PR and payload flow. The new job is marked non-always_run, making it run only when explicitly triggered, and the generated Prow job ordering is adjusted to stay aligned with the source config.

The change also mirrors the structure of the existing openshift/service-ca-operator OTE operator presubmit as the test-plan reference for this new AWS job.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

krisnababu pushed a commit to oharan2/release that referenced this pull request Jul 3, 2026
Add a trigger-only AWS presubmit for the migrated CCCMO disruptive OTE suite so the operator fix and its regression tests can be rehearsed together from the same flow.
andrej1991 pushed a commit to andrej1991/release that referenced this pull request Jul 6, 2026
Add a trigger-only AWS presubmit for the migrated CCCMO disruptive OTE suite so the operator fix and its regression tests can be rehearsed together from the same flow.
TimurMP pushed a commit to TimurMP/release that referenced this pull request Jul 8, 2026
Add a trigger-only AWS presubmit for the migrated CCCMO disruptive OTE suite so the operator fix and its regression tests can be rehearsed together from the same flow.
smulje pushed a commit to smulje/release that referenced this pull request Jul 9, 2026
Add a trigger-only AWS presubmit for the migrated CCCMO disruptive OTE suite so the operator fix and its regression tests can be rehearsed together from the same flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants