Skip to content

[DO-NOT-MERGE] Regression tests for quay 3.10.23#80940

Open
nindsimonv wants to merge 1 commit into
openshift:mainfrom
nindsimonv:regressiontest-3.10.23
Open

[DO-NOT-MERGE] Regression tests for quay 3.10.23#80940
nindsimonv wants to merge 1 commit into
openshift:mainfrom
nindsimonv:regressiontest-3.10.23

Conversation

@nindsimonv

@nindsimonv nindsimonv commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR intended to perform regression tests for quay 3.10.23

Summary by CodeRabbit

This pull request adds comprehensive CI regression test configurations for Quay version 3.10.23 across multiple OpenShift Container Platform versions (4.12, 4.13, 4.14, and 4.15).

What's changing:
Nine new CI operator configuration files have been added to ci-operator/config/quay/quay-tests/, establishing automated regression testing workflows for Quay's upgrade and operator deployment scenarios. For each OCP version (4.12-4.15), the PR introduces three configuration variants:

  1. Operator regression tests - Validates Quay operator functionality across different namespace configurations, running yearly on AWS Quay QE cluster profiles
  2. General regression tests - Runs ACS security violation checks and comprehensive E2E testing with virtual builder deployments, scheduled daily and yearly
  3. Upgrade regression tests - Tests three upgrade scenarios (standard Quay upgrade, CSO-based upgrade, and QBO-based upgrade) with different compute node configurations and operator sources

Infrastructure impact:
These configurations integrate Quay's regression testing into the OpenShift CI system by defining:

  • Base image dependencies and build root configurations for each OCP version
  • Resource allocation limits (8Gi memory, 200m CPU requests)
  • Release stream targeting (OCP nightly candidates for each version)
  • Scheduled test execution with cucushift installer rehearsal workflows
  • Integration with storage provisioning (ODF), operator deployment, and registry components

All tests are pinned to Quay 3.10.23 with stable operator channels, ensuring consistent regression validation across the OCP 4.12-4.15 support matrix. The PR is marked [DO-NOT-MERGE], indicating it's intended as a regression test branch rather than a permanent addition to the codebase.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Adds 12 new CI operator YAML configuration files for Quay 3.10.23 regression testing across OpenShift 4.12, 4.13, 4.14, and 4.15. Each OCP version receives three test variant configs: operator all-namespaces regression, general Quay E2E/ACS regression, and upgrade regression, all running on the aws-quay-qe cluster profile via the cucushift-installer-rehearse-aws-ipi workflow.

Changes

Quay 3.10.23 Regression CI Configs (OCP 4.12–4.15)

Layer / File(s) Summary
Quay operator all-namespaces regression (4.12–4.15)
ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-operator-regression.yaml, ...ocp-413-quay-operator-regression.yaml, ...ocp-414-quay-operator-regression.yaml, ...ocp-415-quay-operator-regression.yaml
Four new yearly-scheduled single-job configs, one per OCP version, running the Quay operator all-namespaces test (quay310-ocp41X-operator-test-allns) via three ordered refs (catalogsource, ODF storage, Quay operator test) with version-specific builder/tools base images and pinned index image digests.
Quay E2E and ACS regression tests (4.12–4.15)
ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-regression.yaml, ...ocp-413-quay-regression.yaml, ...ocp-414-quay-regression.yaml, ...ocp-415-quay-regression.yaml
Four new quay-regression configs each with two scheduled jobs: a cron ACS violations check (quay-acs-violations-check-quay310) and a yearly virtual-builder E2E test (quay-e2e-tests-quay310-ocp41X-virtual-builder), using version-specific CLI/UPI-installer base images, Go 1.18 build root, pinned Quay 3.10.23 digests, and step refs for storage, TLS, builder, operator, and API/E2E.
Quay upgrade regression tests (4.12–4.15)
ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yaml, ...ocp-413-quay-upgrade-regression.yaml, ...ocp-414-quay-upgrade-regression.yaml, ...ocp-415-quay-upgrade-regression.yaml
Four new upgrade-regression configs each defining three yearly jobs (quay310-ocp41X-upgrade, cso-quay310-ocp41X-upgrade, qbo-quay310-ocp41X-upgrade) targeting Quay-Upgrade-High, Quay-CSO-Upgrade-High, and Quay-QBO-Upgrade-High testcases respectively, with per-job compute sizing and operator channel/source differences, 8h timeouts, and version-specific ODF channel settings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • hector-vido
  • Prucek
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and directly identifies the main purpose of the changeset: adding regression tests for Quay version 3.10.23 across multiple OpenShift versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds CI-operator configuration YAML files only, containing no Ginkgo test specifications. The custom check for stable test names applies only to Ginkgo tests, making it not applicable here.
Test Structure And Quality ✅ Passed This PR contains only CI-operator YAML configuration files (12 files), not Ginkgo test code. The custom check for Ginkgo test code quality is not applicable.
Microshift Test Compatibility ✅ Passed PR adds only YAML CI-operator configuration files, not Ginkgo e2e tests. Check requires new Go test code; no test source files were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds 12 YAML CI-Operator configuration files only, not Ginkgo e2e tests. Check applies only to new Ginkgo e2e test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR adds CI operator test configuration files only; no deployment manifests, operator code, or pod scheduling constraints. Topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed The PR adds only YAML CI-operator configuration files for regression tests, not Go source code. The OTE Binary Stdout Contract check applies to Go test binaries and suite setup code, which are not...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds only YAML CI configuration files, not Ginkgo e2e test code. The custom check for IPv6/disconnected network compatibility applies only when new Ginkgo e2e tests are added; it is not app...
No-Weak-Crypto ✅ Passed All 12 new YAML files are CI/CD configuration files with no weak cryptographic algorithms, custom crypto implementations, or non-constant-time secret comparisons detected.
Container-Privileges ✅ Passed No container privilege escalation patterns found in any of the 12 added CI-operator regression test configuration files; no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivileg...
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data (passwords, tokens, API keys, PII, credentials) found in the regression test configuration YAML files. All environment variables contain non-sensitive test parameters and public i...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nindsimonv
Once this PR has been reviewed and has the lgtm label, please assign lizhang19817 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@nindsimonv: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-quay-quay-tests-master-ocp-415-quay-regression-quay-e2e-tests-quay310-ocp415-virtual-builder N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-413-quay-upgrade-regression-cso-quay310-ocp413-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-414-quay-upgrade-regression-quay310-ocp414-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-414-quay-operator-regression-quay310-ocp414-operator-test-allns N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-415-quay-regression-quay-acs-violations-check-quay310 N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-412-quay-operator-regression-quay310-ocp412-operator-test-allns N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-414-quay-upgrade-regression-cso-quay310-ocp414-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-412-quay-upgrade-regression-qbo-quay310-ocp412-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-414-quay-regression-quay-e2e-tests-quay310-ocp414-virtual-builder N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-413-quay-operator-regression-quay310-ocp413-operator-test-allns N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-413-quay-upgrade-regression-qbo-quay310-ocp413-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-415-quay-upgrade-regression-cso-quay310-ocp415-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-415-quay-upgrade-regression-quay310-ocp415-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-412-quay-upgrade-regression-quay310-ocp412-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-412-quay-regression-quay-e2e-tests-quay310-ocp412-virtual-builder N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-415-quay-operator-regression-quay310-ocp415-operator-test-allns N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-414-quay-regression-quay-acs-violations-check-quay310 N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-412-quay-upgrade-regression-cso-quay310-ocp412-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-412-quay-regression-quay-acs-violations-check-quay310 N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-413-quay-regression-quay-acs-violations-check-quay310 N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-414-quay-upgrade-regression-qbo-quay310-ocp414-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-413-quay-upgrade-regression-quay310-ocp413-upgrade N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-413-quay-regression-quay-e2e-tests-quay310-ocp413-virtual-builder N/A periodic Periodic changed
periodic-ci-quay-quay-tests-master-ocp-415-quay-upgrade-regression-qbo-quay310-ocp415-upgrade N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@nindsimonv: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp412-upgrade and
qbo-quay310-ocp412-upgrade are missing explicit timeout configurations, which
means they will use a shorter default timeout and may fail mid-upgrade. Add
`timeout: 8h0m0s` to both jobs at the same YAML level as the `cron` field to
ensure they have sufficient time to complete the upgrade process.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp413-upgrade and
qbo-quay310-ocp413-upgrade are missing explicit timeout specifications at the
same level as their other configurations (cluster_profile, env, test, workflow).
Add a timeout field with the value 8h0m0s to both jobs to ensure they have
sufficient time to complete and prevent inheriting an insufficient default
timeout value.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp414-upgrade and
qbo-quay310-ocp414-upgrade are missing explicit timeout configurations that
prevent default-timeout flakes. Add timeout: 8h0m0s to both jobs at the same
indentation level as the as, cron, and steps fields within each job definition
to match the timeout setting of the preceding job configuration.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp415-upgrade and
qbo-quay310-ocp415-upgrade are missing explicit timeout configurations, which
can cause avoidable timeout failures since upgrade workflows are long-running.
Add a timeout field set to 8h0m0s to both jobs at the same indentation level as
the steps field to maintain consistency with the timeout configuration used in
other jobs in this file.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 33f135f1-406b-4a60-a106-58450a83e86a

📥 Commits

Reviewing files that changed from the base of the PR and between 6e9da54 and a8c534d.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/quay/quay-tests/quay-quay-tests-master-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (12)
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-operator-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-operator-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-upgrade-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-operator-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-upgrade-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-operator-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-regression.yaml
  • ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-upgrade-regression.yaml

Comment on lines +49 to +85
- as: cso-quay310-ocp412-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.2xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-12@sha256:cca10d8b831c5c8b53fe2a40e51261d680237c6a179a5fb9f6d97d3f048ff5cb
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
- as: qbo-quay310-ocp412-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.8xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-12@sha256:cca10d8b831c5c8b53fe2a40e51261d680237c6a179a5fb9f6d97d3f048ff5cb
ODF_OPERATOR_CHANNEL: stable-4.12
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_OPERATOR_SOURCE: fbc-operator-catalog
QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-resource-provisioning-storage-odf
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Add explicit timeout to all upgrade jobs.

Only Line 48 sets timeout: 8h0m0s; the jobs starting at Line 49 and Line 65 omit it, so they can fall back to a shorter default and fail mid-upgrade.

Suggested patch
 - as: cso-quay310-ocp412-upgrade
   cron: '`@yearly`'
   steps:
@@
     test:
     - ref: quay-tests-enable-quay-catalogsource
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 - as: qbo-quay310-ocp412-upgrade
   cron: '`@yearly`'
   steps:
@@
     - ref: quay-tests-quay-deploy-operator
     - ref: quay-tests-quay-deploy-registry-noobaa
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 zz_generated_metadata:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp412-upgrade and
qbo-quay310-ocp412-upgrade are missing explicit timeout configurations, which
means they will use a shorter default timeout and may fail mid-upgrade. Add
`timeout: 8h0m0s` to both jobs at the same YAML level as the `cron` field to
ensure they have sufficient time to complete the upgrade process.

Comment on lines +49 to +85
- as: cso-quay310-ocp413-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.2xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-13@sha256:a2e62cc0ab6ce0ef8bc040a1bebe9a7810eaff27dee112399ee2f0fd772b629a
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
- as: qbo-quay310-ocp413-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.8xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-13@sha256:a2e62cc0ab6ce0ef8bc040a1bebe9a7810eaff27dee112399ee2f0fd772b629a
ODF_OPERATOR_CHANNEL: stable-4.13
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_OPERATOR_SOURCE: fbc-operator-catalog
QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-resource-provisioning-storage-odf
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Add explicit timeout to all upgrade jobs.

Line 48 defines timeout: 8h0m0s, but the jobs beginning at Line 49 and Line 65 omit it and may inherit an insufficient default timeout.

Suggested patch
 - as: cso-quay310-ocp413-upgrade
   cron: '`@yearly`'
   steps:
@@
     test:
     - ref: quay-tests-enable-quay-catalogsource
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 - as: qbo-quay310-ocp413-upgrade
   cron: '`@yearly`'
   steps:
@@
     - ref: quay-tests-quay-deploy-operator
     - ref: quay-tests-quay-deploy-registry-noobaa
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 zz_generated_metadata:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp413-upgrade and
qbo-quay310-ocp413-upgrade are missing explicit timeout specifications at the
same level as their other configurations (cluster_profile, env, test, workflow).
Add a timeout field with the value 8h0m0s to both jobs to ensure they have
sufficient time to complete and prevent inheriting an insufficient default
timeout value.

Comment on lines +49 to +85
- as: cso-quay310-ocp414-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.2xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-14@sha256:26b93452830c59aa09b98609334e352103ced018d27c210b6d7efb304985a41d
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
- as: qbo-quay310-ocp414-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.8xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-14@sha256:26b93452830c59aa09b98609334e352103ced018d27c210b6d7efb304985a41d
ODF_OPERATOR_CHANNEL: stable-4.14
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_OPERATOR_SOURCE: fbc-operator-catalog
QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-resource-provisioning-storage-odf
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Add explicit timeout to all upgrade jobs.

Only the first job (Line 48) has timeout: 8h0m0s; the jobs starting at Line 49 and Line 65 should set the same timeout to avoid default-timeout flakes.

Suggested patch
 - as: cso-quay310-ocp414-upgrade
   cron: '`@yearly`'
   steps:
@@
     test:
     - ref: quay-tests-enable-quay-catalogsource
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 - as: qbo-quay310-ocp414-upgrade
   cron: '`@yearly`'
   steps:
@@
     - ref: quay-tests-quay-deploy-operator
     - ref: quay-tests-quay-deploy-registry-noobaa
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 zz_generated_metadata:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp414-upgrade and
qbo-quay310-ocp414-upgrade are missing explicit timeout configurations that
prevent default-timeout flakes. Add timeout: 8h0m0s to both jobs at the same
indentation level as the as, cron, and steps fields within each job definition
to match the timeout setting of the preceding job configuration.

Comment on lines +49 to +85
- as: cso-quay310-ocp415-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.2xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-15@sha256:016a92ca3f4cf0d71ccb53f9d4fcf686a03329e781c0e49436775c99e3351e58
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
- as: qbo-quay310-ocp415-upgrade
cron: '@yearly'
steps:
cluster_profile: aws-quay-qe
env:
BASE_DOMAIN: quayqe.devcluster.openshift.com
COMPUTE_NODE_REPLICAS: "6"
COMPUTE_NODE_TYPE: m6a.8xlarge
MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-15@sha256:016a92ca3f4cf0d71ccb53f9d4fcf686a03329e781c0e49436775c99e3351e58
ODF_OPERATOR_CHANNEL: stable-4.15
QUAY_OPERATOR_CHANNEL: stable-3.10
QUAY_OPERATOR_SOURCE: fbc-operator-catalog
QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High
QUAY_VERSION: 3.10.23
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-resource-provisioning-storage-odf
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Add explicit timeout to all upgrade jobs.

Line 48 sets timeout: 8h0m0s, but the jobs at Line 49 and Line 65 omit it. For upgrade workflows, that inconsistency can cause avoidable timeout failures.

Suggested patch
 - as: cso-quay310-ocp415-upgrade
   cron: '`@yearly`'
   steps:
@@
     test:
     - ref: quay-tests-enable-quay-catalogsource
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 - as: qbo-quay310-ocp415-upgrade
   cron: '`@yearly`'
   steps:
@@
     - ref: quay-tests-quay-deploy-operator
     - ref: quay-tests-quay-deploy-registry-noobaa
     - ref: quay-tests-test-quay-upgrade
     workflow: cucushift-installer-rehearse-aws-ipi
+  timeout: 8h0m0s
 zz_generated_metadata:
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp415-upgrade and
qbo-quay310-ocp415-upgrade are missing explicit timeout configurations, which
can cause avoidable timeout failures since upgrade workflows are long-running.
Add a timeout field set to 8h0m0s to both jobs at the same indentation level as
the steps field to maintain consistency with the timeout configuration used in
other jobs in this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant