[DO-NOT-MERGE] Regression tests for quay 3.10.23#80940
Conversation
WalkthroughAdds 12 new CI operator YAML configuration files for Quay 3.10.23 regression testing across OpenShift 4.12, 4.13, 4.14, and 4.15. Each OCP version receives three test variant configs: operator all-namespaces regression, general Quay E2E/ACS regression, and upgrade regression, all running on the ChangesQuay 3.10.23 Regression CI Configs (OCP 4.12–4.15)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nindsimonv The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@nindsimonv: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp412-upgrade and
qbo-quay310-ocp412-upgrade are missing explicit timeout configurations, which
means they will use a shorter default timeout and may fail mid-upgrade. Add
`timeout: 8h0m0s` to both jobs at the same YAML level as the `cron` field to
ensure they have sufficient time to complete the upgrade process.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp413-upgrade and
qbo-quay310-ocp413-upgrade are missing explicit timeout specifications at the
same level as their other configurations (cluster_profile, env, test, workflow).
Add a timeout field with the value 8h0m0s to both jobs to ensure they have
sufficient time to complete and prevent inheriting an insufficient default
timeout value.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp414-upgrade and
qbo-quay310-ocp414-upgrade are missing explicit timeout configurations that
prevent default-timeout flakes. Add timeout: 8h0m0s to both jobs at the same
indentation level as the as, cron, and steps fields within each job definition
to match the timeout setting of the preceding job configuration.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-upgrade-regression.yaml`:
- Around line 49-85: The upgrade jobs cso-quay310-ocp415-upgrade and
qbo-quay310-ocp415-upgrade are missing explicit timeout configurations, which
can cause avoidable timeout failures since upgrade workflows are long-running.
Add a timeout field set to 8h0m0s to both jobs at the same indentation level as
the steps field to maintain consistency with the timeout configuration used in
other jobs in this file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 33f135f1-406b-4a60-a106-58450a83e86a
⛔ Files ignored due to path filters (1)
ci-operator/jobs/quay/quay-tests/quay-quay-tests-master-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (12)
ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-operator-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-operator-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-upgrade-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-operator-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-upgrade-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-operator-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-regression.yamlci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-upgrade-regression.yaml
| - as: cso-quay310-ocp412-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.2xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-12@sha256:cca10d8b831c5c8b53fe2a40e51261d680237c6a179a5fb9f6d97d3f048ff5cb | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi | ||
| - as: qbo-quay310-ocp412-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.8xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-12@sha256:cca10d8b831c5c8b53fe2a40e51261d680237c6a179a5fb9f6d97d3f048ff5cb | ||
| ODF_OPERATOR_CHANNEL: stable-4.12 | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_OPERATOR_SOURCE: fbc-operator-catalog | ||
| QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-resource-provisioning-storage-odf | ||
| - ref: quay-tests-quay-deploy-operator | ||
| - ref: quay-tests-quay-deploy-registry-noobaa | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Add explicit timeout to all upgrade jobs.
Only Line 48 sets timeout: 8h0m0s; the jobs starting at Line 49 and Line 65 omit it, so they can fall back to a shorter default and fail mid-upgrade.
Suggested patch
- as: cso-quay310-ocp412-upgrade
cron: '`@yearly`'
steps:
@@
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
- as: qbo-quay310-ocp412-upgrade
cron: '`@yearly`'
steps:
@@
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
zz_generated_metadata:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-412-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp412-upgrade and
qbo-quay310-ocp412-upgrade are missing explicit timeout configurations, which
means they will use a shorter default timeout and may fail mid-upgrade. Add
`timeout: 8h0m0s` to both jobs at the same YAML level as the `cron` field to
ensure they have sufficient time to complete the upgrade process.
| - as: cso-quay310-ocp413-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.2xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-13@sha256:a2e62cc0ab6ce0ef8bc040a1bebe9a7810eaff27dee112399ee2f0fd772b629a | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi | ||
| - as: qbo-quay310-ocp413-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.8xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-13@sha256:a2e62cc0ab6ce0ef8bc040a1bebe9a7810eaff27dee112399ee2f0fd772b629a | ||
| ODF_OPERATOR_CHANNEL: stable-4.13 | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_OPERATOR_SOURCE: fbc-operator-catalog | ||
| QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-resource-provisioning-storage-odf | ||
| - ref: quay-tests-quay-deploy-operator | ||
| - ref: quay-tests-quay-deploy-registry-noobaa | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Add explicit timeout to all upgrade jobs.
Line 48 defines timeout: 8h0m0s, but the jobs beginning at Line 49 and Line 65 omit it and may inherit an insufficient default timeout.
Suggested patch
- as: cso-quay310-ocp413-upgrade
cron: '`@yearly`'
steps:
@@
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
- as: qbo-quay310-ocp413-upgrade
cron: '`@yearly`'
steps:
@@
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
zz_generated_metadata:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-413-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp413-upgrade and
qbo-quay310-ocp413-upgrade are missing explicit timeout specifications at the
same level as their other configurations (cluster_profile, env, test, workflow).
Add a timeout field with the value 8h0m0s to both jobs to ensure they have
sufficient time to complete and prevent inheriting an insufficient default
timeout value.
| - as: cso-quay310-ocp414-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.2xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-14@sha256:26b93452830c59aa09b98609334e352103ced018d27c210b6d7efb304985a41d | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi | ||
| - as: qbo-quay310-ocp414-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.8xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-14@sha256:26b93452830c59aa09b98609334e352103ced018d27c210b6d7efb304985a41d | ||
| ODF_OPERATOR_CHANNEL: stable-4.14 | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_OPERATOR_SOURCE: fbc-operator-catalog | ||
| QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-resource-provisioning-storage-odf | ||
| - ref: quay-tests-quay-deploy-operator | ||
| - ref: quay-tests-quay-deploy-registry-noobaa | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Add explicit timeout to all upgrade jobs.
Only the first job (Line 48) has timeout: 8h0m0s; the jobs starting at Line 49 and Line 65 should set the same timeout to avoid default-timeout flakes.
Suggested patch
- as: cso-quay310-ocp414-upgrade
cron: '`@yearly`'
steps:
@@
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
- as: qbo-quay310-ocp414-upgrade
cron: '`@yearly`'
steps:
@@
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
zz_generated_metadata:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-414-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp414-upgrade and
qbo-quay310-ocp414-upgrade are missing explicit timeout configurations that
prevent default-timeout flakes. Add timeout: 8h0m0s to both jobs at the same
indentation level as the as, cron, and steps fields within each job definition
to match the timeout setting of the preceding job configuration.
| - as: cso-quay310-ocp415-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.2xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-15@sha256:016a92ca3f4cf0d71ccb53f9d4fcf686a03329e781c0e49436775c99e3351e58 | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_UPGRADE_TESTCASE: Quay-CSO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi | ||
| - as: qbo-quay310-ocp415-upgrade | ||
| cron: '@yearly' | ||
| steps: | ||
| cluster_profile: aws-quay-qe | ||
| env: | ||
| BASE_DOMAIN: quayqe.devcluster.openshift.com | ||
| COMPUTE_NODE_REPLICAS: "6" | ||
| COMPUTE_NODE_TYPE: m6a.8xlarge | ||
| MULTISTAGE_PARAM_OVERRIDE_QUAY_INDEX_IMAGE: quay.io/redhat-user-workloads/quay-eng-tenant/stable-3-10-v4-15@sha256:016a92ca3f4cf0d71ccb53f9d4fcf686a03329e781c0e49436775c99e3351e58 | ||
| ODF_OPERATOR_CHANNEL: stable-4.15 | ||
| QUAY_OPERATOR_CHANNEL: stable-3.10 | ||
| QUAY_OPERATOR_SOURCE: fbc-operator-catalog | ||
| QUAY_UPGRADE_TESTCASE: Quay-QBO-Upgrade-High | ||
| QUAY_VERSION: 3.10.23 | ||
| test: | ||
| - ref: quay-tests-enable-quay-catalogsource | ||
| - ref: quay-tests-resource-provisioning-storage-odf | ||
| - ref: quay-tests-quay-deploy-operator | ||
| - ref: quay-tests-quay-deploy-registry-noobaa | ||
| - ref: quay-tests-test-quay-upgrade | ||
| workflow: cucushift-installer-rehearse-aws-ipi |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Add explicit timeout to all upgrade jobs.
Line 48 sets timeout: 8h0m0s, but the jobs at Line 49 and Line 65 omit it. For upgrade workflows, that inconsistency can cause avoidable timeout failures.
Suggested patch
- as: cso-quay310-ocp415-upgrade
cron: '`@yearly`'
steps:
@@
test:
- ref: quay-tests-enable-quay-catalogsource
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
- as: qbo-quay310-ocp415-upgrade
cron: '`@yearly`'
steps:
@@
- ref: quay-tests-quay-deploy-operator
- ref: quay-tests-quay-deploy-registry-noobaa
- ref: quay-tests-test-quay-upgrade
workflow: cucushift-installer-rehearse-aws-ipi
+ timeout: 8h0m0s
zz_generated_metadata:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/quay/quay-tests/quay-quay-tests-master__ocp-415-quay-upgrade-regression.yaml`
around lines 49 - 85, The upgrade jobs cso-quay310-ocp415-upgrade and
qbo-quay310-ocp415-upgrade are missing explicit timeout configurations, which
can cause avoidable timeout failures since upgrade workflows are long-running.
Add a timeout field set to 8h0m0s to both jobs at the same indentation level as
the steps field to maintain consistency with the timeout configuration used in
other jobs in this file.
PR intended to perform regression tests for quay 3.10.23
Summary by CodeRabbit
This pull request adds comprehensive CI regression test configurations for Quay version 3.10.23 across multiple OpenShift Container Platform versions (4.12, 4.13, 4.14, and 4.15).
What's changing:
Nine new CI operator configuration files have been added to
ci-operator/config/quay/quay-tests/, establishing automated regression testing workflows for Quay's upgrade and operator deployment scenarios. For each OCP version (4.12-4.15), the PR introduces three configuration variants:Infrastructure impact:
These configurations integrate Quay's regression testing into the OpenShift CI system by defining:
All tests are pinned to Quay 3.10.23 with stable operator channels, ensuring consistent regression validation across the OCP 4.12-4.15 support matrix. The PR is marked [DO-NOT-MERGE], indicating it's intended as a regression test branch rather than a permanent addition to the codebase.