Skip to content

ROSAENG-8139 | fix: Update cp upgrade job names per new changes to the tests#80934

Open
elveeram wants to merge 1 commit into
openshift:mainfrom
elveeram:editUpgradeJobs
Open

ROSAENG-8139 | fix: Update cp upgrade job names per new changes to the tests#80934
elveeram wants to merge 1 commit into
openshift:mainfrom
elveeram:editUpgradeJobs

Conversation

@elveeram

@elveeram elveeram commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Update cp upgrade job names per new changes to th…
This MR also adds slack notification for the backup jobs.

Summary by CodeRabbit

This pull request adds a new Prow job configuration file for ROSA (Red Hat OpenShift Service on AWS) HCP (Hosted Control Plane) integration testing in the OpenShift release repository.

Changes:

  • Created a new CI configuration file: openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml
  • Defines multiple periodic test jobs for ROSA HCP integration scenarios, including:
    • Auto-node integration tests
    • Backup and restore tests (backup-rest, backup-scale, backup-scale-2)
    • Control plane upgrade tests (cp-up-ip, cp-up-ip2)
    • Other integration scenarios

Key Features:

  • Each job is scheduled to run daily at 8 AM UTC
  • Jobs use nested-podman for container execution and run OCM FVT (Functional Verification Tests)
  • Slack Notifications: All backup and control plane-related jobs are configured to report test results (success, failure, error states) to the #rosa-prow-info Slack channel
  • Jobs mount credentials for AWS and OCM authentication, including JIRA and Slack webhook endpoints
  • 466 lines of new configuration across multiple test job definitions

This PR enables automated CI testing for ROSA HCP deployments and integration scenarios with built-in Slack notification support for backup operations.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a0a5abe5-1649-4f3e-bc47-5a147edafb74

📥 Commits

Reviewing files that changed from the base of the PR and between 81cf958 and 2859e3e.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml

Walkthrough

Six periodic job entries in openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml each receive a new reporter_config block. Each block sets the Prow reporting channel to #rosa-prow-info and enables reporting for success, failure, and error job states.

Changes

ROSA HCP Integration Prow Reporter Config

Layer / File(s) Summary
Add reporter_config to all affected periodic jobs
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml
Inserts reporter_config blocks into six periodic job entries, each configuring channel #rosa-prow-info and job_states_to_report covering success, failure, and error.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved, rehearsals-ack

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions updating cp upgrade job names, but the actual changes add reporter_config sections for Slack notifications to periodic test jobs. Update the title to accurately reflect that the PR adds Slack notification configuration (reporter_config) to periodic test jobs, not just updates job names.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies CI job configuration YAML files only, not Ginkgo test code. The check for stable test names is not applicable to CI configuration files.
Test Structure And Quality ✅ Passed The PR modified Go test files, but none contain Ginkgo test code. All modified test files use standard Go testing.T patterns without Ginkgo Describe/It blocks, so the Ginkgo test quality check is n...
Microshift Test Compatibility ✅ Passed This PR modifies CI job configuration YAML files only; no new Ginkgo e2e test code is added, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds CI configuration and utility code, not new Ginkgo e2e tests; the SNO compatibility check only applies when Ginkgo tests (It/Describe/Context/When) are added.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI/CD job configuration (Prow jobs in ci-operator/config/), not deployment manifests, operator code, or controllers. The check does not apply to CI configuration files.
Ote Binary Stdout Contract ✅ Passed This PR modifies CI/CD configuration YAML files and utility tools, not OTE test binaries. The OTE Binary Stdout Contract check is inapplicable to non-test code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. The changes are limited to CI/CD configuration files (YAML) that add Slack notification reporting for existing jobs. No test code with IPv4 assumption...
No-Weak-Crypto ✅ Passed PR adds MD5/SHA1 usage in new utility scripts for scheduling and file deduplication, not cryptographic purposes. No weak crypto, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or non-constant-time s...
Container-Privileges ✅ Passed No privileged container settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, runAsRoot) found in the modified YAML configuration file.
No-Sensitive-Data-In-Logs ✅ Passed No logging that exposes sensitive data found. The PR adds reporter_config sections that only specify a Slack channel and job states to report—neither contains passwords, tokens, API keys, PII, cred...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@elveeram elveeram changed the title ROSAENG-8139 | fix: Update cp upgrade job names per new changes to th… ROSAENG-8139 | fix: Update cp upgrade job names per new changes to the tests Jun 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@elveeram: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-rest-integration-main N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-scale-2-integration-main N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-scale-integration-main N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-rest-2-integration-main N/A periodic Ci-operator config changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-cp-up-ip-integration-main N/A periodic Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-cpup-ip2-integration-main N/A periodic Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-cpupzfin-integration-main N/A periodic Periodic changed
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-cpupzfn2-integration-main N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot requested review from bmeng and jfrazierRedHat June 23, 2026 16:16
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elveeram
Once this PR has been reviewed and has the lgtm label, please assign ravitri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@elveeram: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant