kube-vip: project onboarding#80926
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughThis PR adds initial CI and Prow configuration for ChangesKube-vip repository onboarding
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/prow/02_config/openshift/kube-vip/_pluginconfig.yaml`:
- Around line 9-12: The plugins section for openshift/kube-vip in the
_pluginconfig.yaml file currently only includes the `approve` plugin, but the
Tide configuration requires the `lgtm` plugin to be enabled as well. Add `lgtm`
to the plugins list under the openshift/kube-vip configuration alongside the
existing `approve` plugin to enable the normal `/lgtm` labeling workflow.
In `@core-services/prow/02_config/openshift/kube-vip/_prowconfig.yaml`:
- Around line 99-104: The excludedBranches list does not include community-4.6
and community-4.7, which creates an overlap since these branches are already
included in a stricter query elsewhere. Add community-4.6 and community-4.7 to
the excludedBranches list in the catch-all query to prevent merges from going
through the weaker label set. Apply the same fix to both occurrences of this
pattern in the file (at lines 99-104 and also at lines 150-154).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4e5f44e3-cb1e-458d-b861-185fd1fe1796
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/kube-vip/openshift-kube-vip-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/kube-vip/openshift-kube-vip-main.yamlcore-services/prow/02_config/openshift/kube-vip/_pluginconfig.yamlcore-services/prow/02_config/openshift/kube-vip/_prowconfig.yaml
|
@mkowalski: |
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The generated config referenced openshift/release:golang-1.26, which does not exist in the imagestream (newest convenience tag is golang-1.25). This caused the [input:root] step to fail when importing the build root: unable to import tag pipeline:root ... quay.io/openshift/ci:openshift_release_golang-1.26 not found Use rhel-9-release-golang-1.26-openshift-5.0, the real Go 1.26 builder tag used by other promoted openshift payload components targeting ocp 5.0.
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Review feedback on the onboarding config: 1. The config had a promotion block targeting ocp/5.0 but defined no images to build, so it would only promote the synthetic src image. kube-vip is not yet onboarded to ART/the OpenShift payload and only ships an upstream Alpine/scratch Dockerfile (not a valid RHEL-based payload image). Remove the promotion block, along with the releases and base_images entries that only existed to serve it, leaving a clean CI-testing-only config (unit + integration tests). Promotion and an images stanza can be re-added once the component is ready to ship to the payload. 2. Trim the Tide queries to the active branches (openshift-4.22 / release-4.22 onward, plus main/master). The repo-init template stamped the full historical 4.0+ branch list, none of which exist for this new repo. Future release branches are appended at branch-cut time, matching other trimmed repos (e.g. bpfman-operator).
|
/pj-rehearse pull-ci-openshift-kube-vip-main-unit-tests |
|
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse help |
|
@mkowalski: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mkowalski: job(s): help either don't exist or were not found to be affected, and cannot be rehearsed |
1 participant
Summary by CodeRabbit
This PR onboards the
openshift/kube-viprepository into OpenShift’s CI infrastructure so pull requests get automated build/test coverage and are handled by the standard Prow/Tide workflows.make unit-tests/make integration-tests) and includes a basicgo test -race ./...test command. It also applies default container resource requests/limits and ties the config metadata to themainbranch.releases/base_imagesentries that were targeted atocp/5.0. This reflects that kube-vip is not yet onboarded to ART/OpenShift payload promotion (it ships upstream Alpine/scratch Dockerfiles rather than RHEL/payload images).openshift-4.22/release-4.22onward, plusmain/master) with corresponding label expectations, avoiding a stale historical branch list.approvebehavior (including LGTM handling) and populates the repoOWNERSfile with the specified approvers/reviewers.In practical terms, kube-vip PRs will now reliably run CI unit/integration tests through OpenShift’s pipeline and follow consistent Prow/Tide approval and merge automation—without enabling image promotion until the component is ready for payload onboarding.