ROSAENG-57139 | ci: Remove skip_if_only_changed from optional provider e2e presubmits#80912
Conversation
…r e2e presubmits PR openshift#80765 added skip_if_only_changed to all e2e-presubmits tests, which caused optional jobs to auto-run on every non-doc PR. Keep doc-only skip on the four critical-high presubmits and variant image builds only. Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe ChangesCI Presubmit Config Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla, jerichokeyne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/check-required-labels |
|
/pj-rehearse ack |
|
@jerichokeyne: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@amandahla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Restore manual-only triggering for optional
terraform-provider-rhcse2e presubmits by removingskip_if_only_changedfrom tests markedoptional: true, while keeping doc-only skip on the four critical-high presubmits and variant image builds.Type of change
ci
Related
ROSAENG-57139
Follow-up to #80765
Changes
skip_if_only_changedfrom 18 optional tests interraform-redhat-terraform-provider-rhcs-main__e2e-presubmits.yaml(includingrosa-hcp-arm-critical-high-presubmit).skip_if_only_changedonrosa-sts-advanced-critical-high-presubmit,rosa-sts-private-critical-high-presubmit,rosa-hcp-advanced-critical-high-presubmit, androsa-hcp-private-critical-high-presubmit.images.skip_if_only_changedunchanged.make jobs WHAT=terraform-redhat/terraform-provider-rhcs.Breaking changes
No.
Testing / validation
make jobs WHAT=terraform-redhat/terraform-provider-rhcs(includesci-operator-checkconfigandsanitize-prow-jobs).always_run: falseand noskip_if_only_changed; critical-high presubmits retainskip_if_only_changed.Made with Cursor
Summary by CodeRabbit
This PR removes the
skip_if_only_changedconfiguration from 18 optional terraform-provider-rhcs E2E presubmit tests in the OpenShift CI system.Practical Impact:
The change restores manual-only triggering behavior for optional tests. Previously, PR
#80765addedskip_if_only_changedglobally to all E2E presubmits, which inadvertently caused optional tests to auto-run on every non-documentation PR. This PR corrects that by restricting the skip behavior to only the four critical-high presubmits (rosa-sts-advanced-critical-high-presubmit,rosa-sts-private-critical-high-presubmit,rosa-hcp-advanced-critical-high-presubmit, androsa-hcp-private-critical-high-presubmit). Optional tests likerosa-hcp-arm-critical-high-presubmitand other optional variants will now require manual triggering as intended.Configuration Changes:
terraform-redhat-terraform-provider-rhcs-main__e2e-presubmits.yamlhave theskip_if_only_changedfield removedskip_if_only_changedconfigurationmake jobsNo breaking changes are introduced by this PR.