[o/external-secrets-operator] ESO-399: Updates configs for new releases of ESO and CM#80905
[o/external-secrets-operator] ESO-399: Updates configs for new releases of ESO and CM#80905bharath-b-rh wants to merge 1 commit into
Conversation
Signed-off-by: Bharath B <bhb@redhat.com>
|
@bharath-b-rh: This pull request references ESO-399 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds new CI operator configurations for Changescert-manager-operator: new 1.20 branch CI and master version bump
external-secrets-operator: new release-1.2 branch CI and main version/filter updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse auto-ack |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/external-secrets-operator/openshift-external-secrets-operator-release-1.2.yaml`:
- Line 74: In the skip_if_only_changed regex pattern, escape all literal dots
that should match file extensions or names precisely. The unescaped dots in
`.dockerignore`, `.golangci.yml`, `.gitignore`, and `.md` are currently being
interpreted as regex wildcards matching any character, which can cause
unintended file matches. Add a backslash before each literal dot (e.g.,
`\.dockerignore` instead of `.dockerignore`, `\.golangci\.yml` instead of
`.golangci.yml`, etc.) to ensure only exact filenames are matched and
skip_if_only_changed behaves as intended.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d87161bb-53c8-456a-b4c1-5a09e950fdf8
⛔ Files ignored due to path filters (5)
ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-cert-manager-1.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/external-secrets-operator/openshift-external-secrets-operator-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/external-secrets-operator/openshift-external-secrets-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/external-secrets-operator/openshift-external-secrets-operator-release-1.2-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (6)
ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-cert-manager-1.20.yamlci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yamlci-operator/config/openshift/external-secrets-operator/openshift-external-secrets-operator-main.yamlci-operator/config/openshift/external-secrets-operator/openshift-external-secrets-operator-release-1.2.yamlcore-services/prow/02_config/openshift/cert-manager-operator/_prowconfig.yamlcore-services/prow/02_config/openshift/external-secrets-operator/_prowconfig.yaml
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-release-1.2-e2e-operator |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-publish-e2e-coverage |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bharath-b-rh: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-e2e-operator |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bharath-b-rh: job(s): pull-ci-openshift-external-secrets-operator-main-publish-e2e-coverage either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-external-secrets-operator-main-e2e-operator pull-ci-openshift-external-secrets-operator-release-1.2-e2e-operator |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@bharath-b-rh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Both |
|
/pj-rehearse ack |
|
@bharath-b-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The PR has below changes
cert-manager-1.20andrelease-1.2branches.Summary by CodeRabbit
This PR adds CI infrastructure support for new branches across two projects (cert-manager-operator and external-secrets-operator) and updates cluster/image versions in their existing pipelines.
New branch support:
cert-manager-1.20branch, establishing the full build and test pipeline for this release (E2E tests across AWS/GCP/Azure, FIPS scanning, verification and unit tests)release-1.2branch with similar pipeline structureVersion updates:
The changes establish proper CI/CD scaffolding for the new release branches while keeping the main development branches current with the latest OpenShift cluster versions.