Skip to content

AGENT-1429: Add SNO IPV4 periodic job for OVE#79640

Open
pawanpinjarkar wants to merge 1 commit into
openshift:mainfrom
pawanpinjarkar:add-sno-ipv4-4-ove
Open

AGENT-1429: Add SNO IPV4 periodic job for OVE#79640
pawanpinjarkar wants to merge 1 commit into
openshift:mainfrom
pawanpinjarkar:add-sno-ipv4-4-ove

Conversation

@pawanpinjarkar
Copy link
Copy Markdown
Contributor

Add a new periodic job for SNO IPV4 OVE

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 21, 2026

@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue.

Details

In response to this:

Add a new periodic job for SNO IPV4 OVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Walkthrough

A new periodic CI test job e2e-agent-sno-ipv4-iso-no-registry-techpreview is added to the OpenShift release configuration. The job targets Equinix bare-metal infrastructure, runs every 8 hours, validates SNO IPv4 scenarios with ISO no-registry boot mode, and includes TechPreview channel configuration.

Changes

New SNO IPv4 ISO no-registry TechPreview CI job

Layer / File(s) Summary
New SNO IPv4 ISO no-registry TechPreview job definition
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
Inserted a new test job entry with cluster profile equinix-ocp-metal, intranet capability, cron: 0 */8 * * * schedule, and DEVSCRIPTS_CONFIG setting SNOL_IPV4 scenario, ISO no-registry mode, ISO builder cache cleanup, AGENT_PLATFORM_TYPE=none, and TechPreviewNoUpgrade flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • openshift/release#79360: Both PRs modify the same nightly-5.0.yaml file by adding periodic e2e-agent-* ISO no-registry TechPreview jobs with 8-hour cron schedules and DEVSCRIPTS_CONFIG scenario settings.
  • openshift/release#78986: Both PRs add test entries for agent-e2e-generic-conformance-iso-no-registry TechPreview runs to the same configuration file, covering different IP/topology variants.

Suggested reviewers

  • sadasu
  • stbenjam
  • sosiouxme
🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references AGENT-1429 and mentions adding an SNO IPv4 periodic job for OVE, which aligns with the changeset that adds a new CI test job entry for SNO IPv4 with ISO no-registry configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR adds a CI configuration YAML entry only; no Ginkgo test code or test names are modified, so the check for stable/deterministic test names is not applicable.
Test Structure And Quality ✅ Passed Custom check for Ginkgo test code quality is not applicable; PR only adds a YAML CI configuration entry, not test code.
Microshift Test Compatibility ✅ Passed This PR only adds CI job configuration for existing tests; no new Ginkgo test code is added. The check applies only to new test definitions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR adds only a CI job configuration for SNO, not new Ginkgo test code. The check applies to new test implementations; since no test source code is added, the check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only a CI test job configuration file, not deployment manifests, operator code, or controllers. The check explicitly applies only to those file types, so it is not applicable here.
Ote Binary Stdout Contract ✅ Passed PR only adds CI config (YAML), not test binary code. OTE Binary Stdout Contract check applies to test source code modifications, which this PR does not contain.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds CI job configuration, not new Ginkgo e2e test code. Custom check applies only to new test declarations (It(), Describe()), not CI config.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from petr-muller and wking May 21, 2026 23:15
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/cc @andfasano @bfournie

@openshift-ci openshift-ci Bot requested review from andfasano and bfournie May 21, 2026 23:16
@pawanpinjarkar
Copy link
Copy Markdown
Contributor Author

/depends on openshift-metal3/dev-scripts#1897

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@pawanpinjarkar: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-sno-ipv4-iso-no-registry-techpreview N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 2183-2196: You added a new CI job definition (as:
e2e-agent-sno-ipv4-iso-no-registry-techpreview with workflow
agent-e2e-generic-conformance-iso-no-registry) in ci-operator/config; run the
repository's downstream artifact generator by executing make update, commit the
modified generated files produced by that command (the ci-operator/ and/or
core-services/openshift-*-generated YAMLs) and include those diffs in this PR so
the new test is reflected in the generated artifacts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2d8ff894-6ad3-439d-a1a7-5bc53a0aae2e

📥 Commits

Reviewing files that changed from the base of the PR and between bc36c6c and 04a2ac0.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2026

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants