Add ROSA Classic STS e2e nightly jobs#78881
Add ROSA Classic STS e2e nightly jobs#78881dustman9000 wants to merge 3 commits intoopenshift:mainfrom
Conversation
Add rosa-e2e-classic workflow and periodic jobs for ROSA Classic STS cluster testing using the rosa-e2e test suite. - New workflow: rosa-e2e-classic using rosa-aws-sts-provision chain with CLUSTER_TOPOLOGY=classic and LABEL_FILTER=Platform:Classic - Add CLUSTER_TOPOLOGY env var to rosa-e2e-test step for topology override (auto-detected from OCM API when empty) - Update test script to handle manager cluster access for both HCP (Management Cluster) and Classic (Hive cluster) via backplane - Add nightly periodic jobs for Classic STS on 4.19 and 4.23
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughAdds ROSA Classic STS e2e test infrastructure: two nightly periodic jobs, a new ChangesROSA Classic STS E2E Testing Infrastructure
sequenceDiagram
participant Periodic as CI Periodic Job
participant Workflow as rosa-e2e-classic Workflow
participant OCM as OCM / Backplane
participant Manager as Manager Cluster
participant Cluster as Provisioned ROSA Cluster
participant Test as rosa-e2e-test
participant AWS as AWS / Cleanup
Periodic->>Workflow: trigger workflow (env: classic, STS=true)
Workflow->>OCM: provision via rosa-aws-sts-provision
OCM->>Manager: ocm backplane login (establish manager access)
Manager->>Workflow: return MANAGEMENT_CLUSTER_ID
Workflow->>Cluster: wait for ready nodes (rosa-cluster-wait-ready-nodes)
Workflow->>Test: run rosa-e2e-test (with LABEL_FILTER Platform:Classic)
Test->>Cluster: execute tests
Workflow->>AWS: post steps (deprovision, account role delete, VPC cleanup, stacks) with best_effort
AWS-->>Workflow: teardown complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml`:
- Around line 133-134: The YAML contains a duplicated top-level key
zz_generated_metadata; remove one of the duplicated zz_generated_metadata
entries so only a single zz_generated_metadata key remains at the top level
(locate the repeated zz_generated_metadata occurrences in the file and delete
the redundant block), ensuring the remaining zz_generated_metadata retains any
necessary child content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 65f3d457-b69c-45c2-98e9-93668e7cf1ca
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (6)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yamlci-operator/step-registry/rosa/e2e/classic/OWNERSci-operator/step-registry/rosa/e2e/classic/rosa-e2e-classic-workflow.metadata.jsonci-operator/step-registry/rosa/e2e/classic/rosa-e2e-classic-workflow.yamlci-operator/step-registry/rosa/e2e/test/rosa-e2e-test-commands.shci-operator/step-registry/rosa/e2e/test/rosa-e2e-test-ref.yaml
| REPLICAS: "2" | ||
| STS: "true" | ||
| workflow: rosa-e2e-classic | ||
| - as: rosa-classic-sts-e2e-nightly-4-23 |
There was a problem hiding this comment.
why do we choose this version? I think it is not enabled for rosa yet.
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@dustman9000: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
rosa-e2e-classicworkflow for ROSA Classic STS cluster testing using the rosa-e2e test suiteCLUSTER_TOPOLOGYenv var to therosa-e2e-teststep for explicit topology overrideNew files
ci-operator/step-registry/rosa/e2e/classic/rosa-e2e-classic-workflow.yaml- Classic STS workflow usingrosa-aws-sts-provisionchainci-operator/step-registry/rosa/e2e/classic/OWNERS- Same ownership as rosa/e2eModified files
ci-operator/step-registry/rosa/e2e/test/rosa-e2e-test-ref.yaml- Add CLUSTER_TOPOLOGY env, update docs for multi-topologyci-operator/step-registry/rosa/e2e/test/rosa-e2e-test-commands.sh- Pass CLUSTER_TOPOLOGY, handle HCP vs Classic backplane accessci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__periodics.yaml- Add Classic STS nightly jobsci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml- GeneratedContext
rosa-e2e recently added ROSA Classic STS support (openshift-online/rosa-e2e#27, #28). This PR adds the CI jobs to exercise that support nightly.
Test plan
make jobsgenerates expected periodic job definitionsmake registry-metadatapassesrosa-classic-sts-e2e-nightly-4-23after merge bot posts rehearsal notifierSummary by CodeRabbit
New Features
Chores