Skip to content

chore: clean up org stolostron-engine#78862

Open
dhaiducek wants to merge 1 commit intoopenshift:mainfrom
dhaiducek:stolostron-engine
Open

chore: clean up org stolostron-engine#78862
dhaiducek wants to merge 1 commit intoopenshift:mainfrom
dhaiducek:stolostron-engine

Conversation

@dhaiducek
Copy link
Copy Markdown
Contributor

@dhaiducek dhaiducek commented May 5, 2026

Summary by CodeRabbit

  • Chores
    • Removed stolostron-engine CI/CD infrastructure including image mirroring, manifest update, and RBAC workflows and steps.
    • Removed stolostron-engine approval and governance configuration files.
    • Removed stolostron-engine Kubernetes namespace and associated RBAC resources from registry access configuration.
    • Removed stolostron-engine Prow plugin and pipeline configuration.

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6065d066-3ab3-4718-8100-7669719fe7f9

📥 Commits

Reviewing files that changed from the base of the PR and between 0753d8d and cc7a49c.

📒 Files selected for processing (32)
  • ci-operator/config/stolostron-engine/OWNERS
  • ci-operator/step-registry/stolostron-engine/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-commands.sh
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-commands.sh
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-commands.sh
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/rbac/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-commands.sh
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-workflow.yaml
  • clusters/app.ci/registry-access/stolostron-engine/OWNERS
  • clusters/app.ci/registry-access/stolostron-engine/admin_stolostron-engine.yaml
  • core-services/prow/02_config/stolostron-engine/OWNERS
  • core-services/prow/02_config/stolostron-engine/_pluginconfig.yaml
  • core-services/prow/02_config/stolostron-engine/_prowconfig.yaml
💤 Files with no reviewable changes (32)
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/OWNERS
  • ci-operator/config/stolostron-engine/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/rbac/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-ref.metadata.json
  • core-services/prow/02_config/stolostron-engine/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-workflow.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-commands.sh
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-workflow.metadata.json
  • clusters/app.ci/registry-access/stolostron-engine/admin_stolostron-engine.yaml
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-workflow.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-commands.sh
  • ci-operator/step-registry/stolostron-engine/OWNERS
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-commands.sh
  • core-services/prow/02_config/stolostron-engine/_pluginconfig.yaml
  • clusters/app.ci/registry-access/stolostron-engine/OWNERS
  • core-services/prow/02_config/stolostron-engine/_prowconfig.yaml
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/stolostron-engine-ci-image-mirror-periodic-ref.yaml
  • ci-operator/step-registry/stolostron-engine/ci/rbac/stolostron-engine-ci-rbac-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-ref.metadata.json
  • ci-operator/step-registry/stolostron-engine/ci/manifest-update/stolostron-engine-ci-manifest-update-commands.sh
  • ci-operator/step-registry/stolostron-engine/ci/image-mirror/stolostron-engine-ci-image-mirror-ref.yaml

Walkthrough

This PR removes all CI/CD infrastructure configuration and orchestration for the stolostron-engine project, including Prow automation policies, step registry definitions, ownership records, and Kubernetes registry access resources. Approximately 35 files are deleted across multiple subsystems.

Changes

Removal of stolostron-engine CI Infrastructure

Layer / File(s) Summary
Ownership Cleanup
ci-operator/config/stolostron-engine/OWNERS, ci-operator/step-registry/stolostron-engine/OWNERS, ci-operator/step-registry/stolostron-engine/ci/OWNERS, ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/OWNERS, ci-operator/step-registry/stolostron-engine/ci/image-mirror/OWNERS, ci-operator/step-registry/stolostron-engine/ci/manifest-update/OWNERS, ci-operator/step-registry/stolostron-engine/ci/rbac/OWNERS, clusters/app.ci/registry-access/stolostron-engine/OWNERS, core-services/prow/02_config/stolostron-engine/OWNERS
All approvers, reviewers, and emeritus approvers entries removed from ownership files across config, step registry, registry access, and Prow subsystems.
Prow Policy Configuration
core-services/prow/02_config/stolostron-engine/_pluginconfig.yaml, core-services/prow/02_config/stolostron-engine/_prowconfig.yaml
Prow plugin config (approve, lgtm, triggers, external plugins) and Tide merge policy (squash method, label requirements) deleted entirely.
CI Step Registry Definitions
ci-operator/step-registry/stolostron-engine/ci/rbac/*, ci-operator/step-registry/stolostron-engine/ci/image-mirror/*, ci-operator/step-registry/stolostron-engine/ci/image-mirror-periodic/*, ci-operator/step-registry/stolostron-engine/ci/manifest-update/*
All step definitions, metadata, commands, and workflows removed for four step types: rbac (RBAC privilege provisioning), image-mirror (production image mirroring), image-mirror-periodic (periodic mirror), and manifest-update (OCM manifest publication).
Infrastructure Resources
clusters/app.ci/registry-access/stolostron-engine/admin_stolostron-engine.yaml
Kubernetes namespace stolostron-engine, ServiceAccount image-pusher, Role image-tagger, and all associated RoleBindings for image push/pull/admin access removed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the pull request's primary objective: removing configuration, workflows, and ownership entries across multiple directories related to the stolostron-engine organization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The custom check for Ginkgo test names is not applicable. The PR only modifies configuration files, shell scripts, and Kubernetes manifests—no Go test files or Ginkgo tests.
Test Structure And Quality ✅ Passed Not applicable. This PR contains only configuration, CI/CD, and Kubernetes manifest files. No Go test code or Ginkgo tests are present.
Microshift Test Compatibility ✅ Passed PR does not add any new Ginkgo e2e tests. MicroShift Test Compatibility check only applies when new tests are added. This PR only removes CI/CD configuration and infrastructure files.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The PR only cleans up stolostron-engine CI configuration files (OWNERS, workflows, steps). SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes stolostron-engine CI/RBAC resources. No new deployment manifests or controllers with topology-specific scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed PR only removes CI configuration files (YAML, OWNERS, shell scripts, Prow configs) for stolostron-engine. No OTE binary, test, or suite setup code is modified. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR removes CI infrastructure and configuration files. No new Ginkgo e2e tests are being added, so the IPv6/disconnected network compatibility check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhaiducek
Once this PR has been reviewed and has the lgtm label, please assign mark-nc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from gurnben and mark-nc May 5, 2026 17:50
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@dhaiducek: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant