Skip to content

Provision 4.22 nightly cluster#78861

Open
kabirbhartiRH wants to merge 1 commit intoopenshift:mainfrom
kabirbhartiRH:aws-test-4.22-cluster
Open

Provision 4.22 nightly cluster#78861
kabirbhartiRH wants to merge 1 commit intoopenshift:mainfrom
kabirbhartiRH:aws-test-4.22-cluster

Conversation

@kabirbhartiRH
Copy link
Copy Markdown
Contributor

@kabirbhartiRH kabirbhartiRH commented May 5, 2026

Provision test cluster. do not merge

Summary by CodeRabbit

  • Chores
    • Updated test infrastructure configuration to optimize resource allocation and streamline testing workflows.

@kabirbhartiRH
Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Walkthrough

The aws-ipi-amd-f999-logging test configuration in the release 4.22 multi-nightly OpenShift logging pipeline is modified to replace the prior logging operator installation and E2E test execution steps with a single four-hour sleep step, removing all logging-specific environment variables and test filters.

Changes

CI Test Configuration Update

Layer / File(s) Summary
Test Definition
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly-openshift-logging-6.5.yaml
The aws-ipi-amd-f999-logging test's steps block is updated: OCP_ARCH: amd64 is set, and the multi-step logging operator installation chain (openshift-logging-catalogsources, install-operators, openshift-e2e-test-logging-qe) is replaced by a single sleep-xhours step executing sleep 4h with 512Mi/100m resource limits. Logging environment variables (LOGGING_TEST_VERSION, OPERATORS) and test filters (TEST_FILTERS, TEST_SCENARIOS, TEST_TIMEOUT) are removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Topology-Aware Scheduling Compatibility ⚠️ Warning The PR adds a DaemonSet (crt-admission-webhooks) with nodeSelector targeting node-role.kubernetes.io/master, which will fail on HyperShift topologies where no control-plane nodes exist in-cluster. Remove the nodeSelector from crt-admission-webhooks DaemonSet or add topology-aware checks for ControlPlaneTopology before applying control-plane node constraints. Consider using only tolerations without nodeSelector.
Title check ❓ Inconclusive The title 'Provision 4.22 nightly cluster' is vague and generic. It doesn't clearly convey the specific change being made (replacing logging E2E tests with a sleep step). Use a more descriptive title that explains the actual change, such as 'Replace logging E2E tests with sleep step in 4.22 nightly config' or similar.
✅ Passed checks (10 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Check not applicable. PR modifies CI operator configuration YAML files only, not Ginkgo test code. Repository contains CI/CD config, not test implementations.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this PR. The PR modifies CI operator configuration (YAML files only), not test code. No Ginkgo tests are present in the changes.
Microshift Test Compatibility ✅ Passed Not applicable. The custom check applies only to new Ginkgo e2e test code. This PR modifies CI configuration files (YAML) only and does not add any new Go test code or Ginkgo tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR modifies a CI operator YAML config file only. SNO check not applicable to this PR.
Ote Binary Stdout Contract ✅ Passed This PR modifies only YAML CI configuration files. The OTE Binary Stdout Contract check applies to process-level code in binary implementations, not CI configuration.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only a CI configuration YAML file and does not add any new Ginkgo e2e test code. The custom check applies only when new tests are added, which is not the case here.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kabirbhartiRH
Once this PR has been reviewed and has the lgtm label, please assign amoghrd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from asood-rh and jechen0648 May 5, 2026 17:50
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly-openshift-logging-6.5.yaml (1)

10-17: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

tests-private and tests-private-ui base images reference "4.21" while the file targets 4.22.

All other versioned base images (cli, tools, upi-installer) reference "4.22", but tests-private and tests-private-ui remain at "4.21". While the current sleep-step test does not consume these images and this PR is a temporary cluster provisioning exercise, leaving mismatched image tags here means restoring the actual E2E logging test chain later would silently use a 4.21 test image against a 4.22 cluster.

🔧 Proposed fix
   tests-private:
     name: tests-private
     namespace: ci
-    tag: "4.21"
+    tag: "4.22"
   tests-private-ui:
     name: tests-private-ui
     namespace: ci
-    tag: "4.21"
+    tag: "4.22"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly-openshift-logging-6.5.yaml`
around lines 10 - 17, Update the mismatched base image tags for tests-private
and tests-private-ui to match the file target version: change the tag field
value for the tests-private and tests-private-ui entries (symbols
"tests-private" and "tests-private-ui" with their "tag" keys) from "4.21" to
"4.22" so all versioned base images are consistent with the 4.22 target.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly-openshift-logging-6.5.yaml`:
- Around line 10-17: Update the mismatched base image tags for tests-private and
tests-private-ui to match the file target version: change the tag field value
for the tests-private and tests-private-ui entries (symbols "tests-private" and
"tests-private-ui" with their "tag" keys) from "4.21" to "4.22" so all versioned
base images are consistent with the 4.22 target.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1189a35a-70b5-4e5e-8874-c830e3d20d5c

📥 Commits

Reviewing files that changed from the base of the PR and between 0753d8d and 790f366.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly-openshift-logging-6.5.yaml

@kabirbhartiRH
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-openshift-logging-6.5-aws-ipi-amd-f999-logging

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@kabirbhartiRH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@kabirbhartiRH
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-openshift-logging-6.5-aws-ipi-amd-f999-logging

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@kabirbhartiRH: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@kabirbhartiRH: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-openshift-logging-6.5-aws-ipi-amd-f999-logging 790f366 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-openshift-logging-6.5-aws-ipi-amd-f999-logging

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant