Skip to content

mco: add ocl jobs to pipeline#78856

Open
djoshy wants to merge 1 commit intoopenshift:mainfrom
djoshy:pipeline-ocl
Open

mco: add ocl jobs to pipeline#78856
djoshy wants to merge 1 commit intoopenshift:mainfrom
djoshy:pipeline-ocl

Conversation

@djoshy
Copy link
Copy Markdown
Contributor

@djoshy djoshy commented May 5, 2026

These jobs were made required in #78253, let's have them run in the 2nd stage of the pipeline.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD test pipeline configuration to improve efficiency by streamlining test execution when only documentation, metadata files, and license information are modified.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4c09ce04-16b7-4424-a649-c1a4af6952fc

📥 Commits

Reviewing files that changed from the base of the PR and between 0f3802d and 11305fb.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml

Walkthrough

Two GCP OCL e2e jobs in the machine-config-operator CI configuration are updated to use the standardized pipeline_skip_if_only_changed field instead of skip_if_only_changed, with the same skip regex pattern retained for both jobs.

Changes

CI Job Configuration Field Alignment

Layer / File(s) Summary
Field Name Convention Update
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml
e2e-gcp-op-ocl-part1 and e2e-gcp-op-ocl-part2 job definitions replace skip_if_only_changed with pipeline_skip_if_only_changed field, maintaining the same regex pattern ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|OWNERS_ALIASES|LICENSE)$ to skip pipeline execution when only docs, markdown, or metadata files change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'mco: add ocl jobs to pipeline' is partially related but incomplete—it mentions adding OCL jobs to the pipeline, yet the actual changes involve migrating from 'skip_if_only_changed' to 'pipeline_skip_if_only_changed' for existing OCL jobs, which is not fully captured in the title. Consider clarifying the title to reflect the actual change: e.g., 'mco: migrate ocl jobs to use pipeline_skip_if_only_changed' or 'mco: update ocl job skip conditions for pipeline stage' would better describe the field migration.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR adds CI/CD configuration YAML files, not Ginkgo test code. The check applies to Ginkgo test declarations in Go files, which are not present in this PR.
Test Structure And Quality ✅ Passed The custom check is about reviewing Ginkgo test code quality. This PR only modifies CI/CD configuration YAML files and contains no actual Go test code. The check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The changes are purely CI/CD configuration files (YAML) to enable existing OCL tests in the pipeline. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds CI configuration for OCL e2e jobs but no new Ginkgo test code. SNO check applies only to new test implementations, not CI config changes.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies CI configuration only (ci-operator config), not deployment manifests, operator code, or controllers. The custom check explicitly applies only to those entity types.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI/CD configuration files. OTE Binary Stdout Contract applies to Go source code (main, init, logging); this PR contains no executable code that could violate the contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Check is not applicable. This PR modifies CI configuration (YAML) only, and does not add any new Ginkgo e2e tests. The custom check specifically applies to new Ginkgo e2e tests being added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from pablintino and yuqi-zhang May 5, 2026 16:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Forget if we need to explicitly do this for the 5.0 branch definition as well?

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants