USHIFT-6899: Move MicroShift CI Doctor under openshift/edge-tooling for consistency#78854
USHIFT-6899: Move MicroShift CI Doctor under openshift/edge-tooling for consistency#78854ggiguash wants to merge 3 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ggiguash: This pull request references USHIFT-6899 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (15)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughMoves the microshift CI doctor from openshift/microshift into openshift-eng/edge-tooling: updates step/workflow aliases and command script names, adjusts metadata paths, adds the microshift-ci-doctor test and periodic under edge-tooling while removing the original microshift entries, and updates Slack reporter configurations and report URLs. ChangesMicroshift CI Doctor migration and CI wiring
Sequence Diagram(s)sequenceDiagram
participant Scheduler as Prow Cron Scheduler
participant PeriodicJob as Prow Periodic Job
participant Workflow as Step Registry Workflow
participant TestContainer as CI Test Container
participant PostStep as Post step (report generation)
participant GCS as GCS artifacts
participant Slack as Slack Reporter
Scheduler->>PeriodicJob: cron triggers periodic (microshift-ci-doctor)
PeriodicJob->>Workflow: invoke workflow ref (openshift-edge-tooling-microshift-ci-doctor)
Workflow->>TestContainer: run test commands
TestContainer->>PostStep: produce artifacts, invoke post step
PostStep->>GCS: upload microshift-ci-doctor report.html
PostStep->>Slack: emit report metadata (status, URLs)
Slack->>Slack: format message with GCS report link and logs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift-eng/edge-tooling/.config.prowgen`:
- Line 19: The "View report" Slack link hardcodes the old doctor step name and
must be updated to use the new step alias; replace the path segment
"ci-doctor/openshift-microshift-claude-ci-doctor" with the new step alias
"ci-doctor/openshift-edge-tooling-microshift-ci-doctor" so the template's URL
points at the artifact produced by the
openshift-edge-tooling-microshift-ci-doctor step (keep the surrounding template
variables like {{.Spec.Job}}/{{.Status.BuildID}} intact).
In
`@ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-periodics.yaml`:
- Line 24: Update the report_template string used for Slack notifications (the
template containing the "View report" GCS URL) to use the migrated artifact path
segments: replace the stale
"artifacts/ci-doctor/openshift-microshift-claude-ci-doctor/artifacts/microshift-ci-doctor-report.html"
with
"artifacts/microshift-ci-doctor/openshift-edge-tooling-microshift-ci-doctor/artifacts/microshift-ci-doctor-report.html"
so the template (report_template) reflects the --target=microshift-ci-doctor and
the renamed step (openshift-edge-tooling-microshift-ci-doctor) and the "View
report" link resolves correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 68f08ef1-9b31-4b40-be21-99f3c017bfe5
📒 Files selected for processing (17)
ci-operator/config/openshift-eng/edge-tooling/.config.prowgenci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yamlci-operator/config/openshift/microshift/.config.prowgenci-operator/config/openshift/microshift/openshift-microshift-main.yamlci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-periodics.yamlci-operator/jobs/openshift/microshift/openshift-microshift-main-periodics.yamlci-operator/step-registry/openshift/edge-tooling/microshift-ci/OWNERSci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/OWNERSci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-commands.shci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-ref.metadata.jsonci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-ref.yamlci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-workflow.metadata.jsonci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-workflow.yamlci-operator/step-registry/openshift/edge-tooling/microshift-ci/post/OWNERSci-operator/step-registry/openshift/edge-tooling/microshift-ci/post/openshift-edge-tooling-microshift-ci-post-commands.shci-operator/step-registry/openshift/edge-tooling/microshift-ci/post/openshift-edge-tooling-microshift-ci-post-ref.metadata.jsonci-operator/step-registry/openshift/edge-tooling/microshift-ci/post/openshift-edge-tooling-microshift-ci-post-ref.yaml
💤 Files with no reviewable changes (3)
- ci-operator/config/openshift/microshift/openshift-microshift-main.yaml
- ci-operator/config/openshift/microshift/.config.prowgen
- ci-operator/jobs/openshift/microshift/openshift-microshift-main-periodics.yaml
|
/pj-rehearse ? |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse ? |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ? |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse ? |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ggiguash, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse list |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ggiguash, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse list |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ggiguash, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml (1)
118-124: ⚡ Quick winThe
microshift-ci-doctorjob omitsrestrict_network_access, consistent with the existingocp-ci-monitorjob.The new job follows the established pattern in this file. While
pr-notifierexplicitly setsrestrict_network_access: falseto support GitHub API calls, bothocp-ci-doctorandmicroshift-ci-doctor(which also requires external network access for Claude AI processing) omit this flag. Since the existingocp-ci-monitorjob functions without it, the absence here is likely intentional or the default behavior permits network access. If the behavior is inconsistent with intentions, this should be addressed uniformly across both jobs, not just the new one.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml` around lines 118 - 124, The new job definition for microshift-ci-doctor omits the restrict_network_access flag (like ocp-ci-monitor) which may cause inconsistent network permissions compared to pr-notifier; update the microshift-ci-doctor job block (workflow: openshift-edge-tooling-microshift-ci-doctor) to explicitly include restrict_network_access: false if external network (Claude AI/GitHub API) is required, or add the same explicit setting to ocp-ci-monitor to keep behavior uniform—modify the job entries for microshift-ci-doctor and/or ocp-ci-monitor to consistently include the restrict_network_access field matching intended network access.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml`:
- Around line 118-124: The new job definition for microshift-ci-doctor omits the
restrict_network_access flag (like ocp-ci-monitor) which may cause inconsistent
network permissions compared to pr-notifier; update the microshift-ci-doctor job
block (workflow: openshift-edge-tooling-microshift-ci-doctor) to explicitly
include restrict_network_access: false if external network (Claude AI/GitHub
API) is required, or add the same explicit setting to ocp-ci-monitor to keep
behavior uniform—modify the job entries for microshift-ci-doctor and/or
ocp-ci-monitor to consistently include the restrict_network_access field
matching intended network access.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 399cb55a-bff2-44a7-afe3-3d0c48876ff6
📒 Files selected for processing (1)
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml
ggiguash
force-pushed
the
ci-doctor-to-edge-tooling
branch
from
9f45bc8 to
7d80793
Compare
|
/pj-rehearse list |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
ggiguash
force-pushed
the
ci-doctor-to-edge-tooling
branch
from
4b45455 to
ea2ca52
Compare
|
/pj-rehearse periodic-ci-openshift-eng-edge-tooling-main-microshift-ci-doctor |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
2 participants
Summary by CodeRabbit
New Features
Chores