[Debug] Add wait step to e2e-aws-mno-qe-integration-tests for OCP 4.22 by mmakwana30 · Pull Request #78844 · openshift/release

mmakwana30 · 2026-05-05T14:51:41Z

This adds a wait step to enable debugging of test failures in OCP 4.22.

The wait step pauses the workflow before tests run, allowing QE to:

SSH into the test environment
Inspect system state and logs
Debug configuration issues
Investigate test failures

OCP Version: 4.22
Job: e2e-aws-mno-qe-integration-tests
Timeout: 8 hours

Summary by CodeRabbit

Chores
- Adjusted test timeout to 8 hours for integration test job.
- Added preparatory step to test execution sequence.

This adds a wait step to enable debugging of test failures in OCP 4.22. The wait step pauses the workflow before tests run, allowing QE to: - SSH into the test environment - Inspect system state and logs - Debug configuration issues - Investigate test failures OCP Version: 4.22 Job: e2e-aws-mno-qe-integration-tests Timeout: 8 hours

coderabbitai · 2026-05-05T14:52:22Z

Walkthrough

A CI configuration update adds an 8-hour timeout environment variable and inserts a wait step before the existing test step in the e2e-aws-mno-qe-integration-tests job for the LVM operator.

Changes

CI Test Job Configuration

Layer / File(s)	Summary
Environment & Test Orchestration `ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main.yaml`	`e2e-aws-mno-qe-integration-tests` job now sets `TIMEOUT: +8 hours` in env section and adds `- ref: wait` step before the `lvms-mno-integration-test` step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: adding a wait step to the e2e-aws-mno-qe-integration-tests job with a specific OCP version reference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies CI/CD YAML configuration, not Ginkgo test code. No test title declarations (It(), Describe(), etc.) or Go test files are changed. Check is not applicable.
Test Structure And Quality	✅ Passed	Check not applicable. PR modifies only CI configuration YAML, not Ginkgo test code.
Microshift Test Compatibility	✅ Passed	The PR contains only a CI configuration change (YAML file). No new Ginkgo e2e tests are being added, making the MicroShift Test Compatibility check inapplicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. Only CI configuration YAML is modified. SNO check applies only to new tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes only CI operator configuration, not deployment manifests or operator code. No topology-aware scheduling constraints are introduced. The check is not applicable to CI configuration files.
Ote Binary Stdout Contract	✅ Passed	PR contains only YAML CI configuration changes, no source code. OTE Binary Stdout Contract check applies only to source code files, not CI configuration YAML.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies only CI job configuration (YAML), not test code. No new Ginkgo e2e tests are added. The check targets new test code with IPv4/connectivity issues, which is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-05T14:53:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmakwana30
Once this PR has been reviewed and has the lgtm label, please assign jeff-roche for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

ci-operator/config/openshift/lvm-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-05-05T14:55:01Z

[REHEARSALNOTIFIER]
@mmakwana30: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-lvm-operator-main-e2e-aws-mno-qe-integration-tests	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main.yaml`:
- Around line 346-349: The 8-hour hardcoded wait (TIMEOUT: +8 hours) is causing
all weekly runs to idle; change the job so that the "+8 hours" wait is only
applied for a debug variant or when a debug flag is set. Modify the job config
around TIMEOUT and the test block that references the "wait" ref/as
"lvms-mno-integration-test" to add a gated variant (e.g., create a separate
debug job or wrap the TIMEOUT modification in a conditional like debug=true) so
the regular weekly job keeps the normal timeout while the debug variant retains
TIMEOUT: +8 hours and the test ref: wait entry.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 905f5a4e-dc25-4e9c-935c-75e717bde965

📥 Commits

Reviewing files that changed from the base of the PR and between b83e6b3 and 9a35e5c.

📒 Files selected for processing (1)

ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main.yaml

coderabbitai · 2026-05-05T14:56:34Z

+      TIMEOUT: +8 hours
    test:
+    - ref: wait
    - as: lvms-mno-integration-test


⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Make the 8-hour wait debug-only instead of always-on in the weekly job.

With the current change, every scheduled weekly run idles for 8 hours before tests, which can significantly delay signal and tie up AWS/lease capacity; it may also push total runtime beyond job timeout budgets once install + test time are included. Please move this into a dedicated debug variant (or otherwise gate it) so the regular periodic keeps its normal runtime.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main.yaml` around lines 346 - 349, The 8-hour hardcoded wait (TIMEOUT: +8 hours) is causing all weekly runs to idle; change the job so that the "+8 hours" wait is only applied for a debug variant or when a debug flag is set. Modify the job config around TIMEOUT and the test block that references the "wait" ref/as "lvms-mno-integration-test" to add a gated variant (e.g., create a separate debug job or wrap the TIMEOUT modification in a conditional like debug=true) so the regular weekly job keeps the normal timeout while the debug variant retains TIMEOUT: +8 hours and the test ref: wait entry.

This is just for debugging something and we have no plans of merging this code in.

@kasturinarra, understood — thanks for the clarification! Since this is a temporary debug PR that won't be merged, the concern doesn't apply. Happy debugging! 🙂

openshift-ci · 2026-05-05T15:01:23Z

@mmakwana30: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mmakwana30 · 2026-05-05T15:01:30Z

/pj-rehearse periodic-ci-openshift-lvm-operator-main-e2e-aws-mno-qe-integration-tests

openshift-merge-bot · 2026-05-05T15:01:33Z

@mmakwana30: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

kasturinarra · 2026-05-05T16:45:23Z

/pj-rehearse periodic-ci-openshift-lvm-operator-main-e2e-aws-mno-qe-integration-tests

openshift-merge-bot · 2026-05-05T16:45:26Z

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

kasturinarra · 2026-05-05T17:05:49Z

/pj-rehearse periodic-ci-openshift-lvm-operator-main-e2e-aws-mno-qe-integration-tests

openshift-merge-bot · 2026-05-05T17:05:52Z

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

kasturinarra · 2026-05-06T05:29:58Z

/pj-rehearse periodic-ci-openshift-lvm-operator-main-e2e-aws-mno-qe-integration-tests

openshift-merge-bot · 2026-05-06T05:30:00Z

@kasturinarra: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci Bot requested review from jerpeter1 and suleymanakbas91 May 5, 2026 14:52

coderabbitai Bot reviewed May 5, 2026

View reviewed changes

Conversation

mmakwana30 commented May 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kasturinarra May 5, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot May 5, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

mmakwana30 commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

kasturinarra commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

kasturinarra commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

kasturinarra commented May 6, 2026

Uh oh!

openshift-merge-bot Bot commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mmakwana30 commented May 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 5, 2026 •

edited

Loading

coderabbitai Bot May 5, 2026 •

edited

Loading