Skip to content

hypershift: promote e2e-v2-gke to pipelined required test#78842

Open
cblecker wants to merge 1 commit intoopenshift:mainfrom
cblecker:e2e-v2-gke-pipeline
Open

hypershift: promote e2e-v2-gke to pipelined required test#78842
cblecker wants to merge 1 commit intoopenshift:mainfrom
cblecker:e2e-v2-gke-pipeline

Conversation

@cblecker
Copy link
Copy Markdown
Member

@cblecker cblecker commented May 5, 2026 •
edited by coderabbitai Bot
Loading

Summary

  • Removes optional: true from e2e-v2-gke so the test is required to pass (like e2e-v2-aws)
  • Replaces run_if_changed (GCP-file-only trigger) with pipeline_skip_if_only_changed (docs-skip regex) so the job runs on all code-changing PRs as a pipelined test
  • Applied across main and release branches 4.22, 4.23, 5.0, and 5.1; capabilities: [build-tmpfs] and cluster_profile: hypershift-gcp are unchanged

Test plan

  • Verify rehearsal triggers e2e-v2-gke on a normal code-change PR (not just GCP-file changes)
  • Confirm the job no longer appears as optional in the PR status checks
  • Confirm docs-only PRs correctly skip e2e-v2-gke via the pipeline skip regex

Summary by CodeRabbit

  • Chores
    • Updated GCP GKE end-to-end test triggering logic across multiple release versions to skip execution when only non-code and documentation-related files change, improving CI pipeline efficiency.

@cblecker
hypershift: promote e2e-v2-gke to pipelined required test
f26eec6 
Remove optional:true and replace run_if_changed (GCP-file-only trigger)
with pipeline_skip_if_only_changed (docs-skip regex) so e2e-v2-gke runs
on all code-changing PRs alongside e2e-v2-aws, across main and release
branches 4.22, 4.23, 5.0, and 5.1.

Assisted-by: Claude:claude-sonnet-4-6[1m]
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8c25ac7a-faa2-4559-b0b5-03f74c354709

📥 Commits

Reviewing files that changed from the base of the PR and between b83e6b3 and f26eec6.

⛔ Files ignored due to path filters (5)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1.yaml

Walkthrough

The PR updates the e2e-v2-gke test job trigger condition across five HyperShift CI configuration files (main and release 4.22, 4.23, 5.0, 5.1 branches). Each change replaces run_if_changed (GCP-specific paths) with pipeline_skip_if_only_changed (broad non-code paths), standardizing when the job executes.

Changes

HyperShift e2e-v2-gke Trigger Condition Migration

Layer / File(s) Summary
Trigger Condition Update
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml, openshift-hypershift-release-4.22.yaml, openshift-hypershift-release-4.23.yaml, openshift-hypershift-release-5.0.yaml, openshift-hypershift-release-5.1.yaml		 Replaces run_if_changed (GCP-specific regex) with pipeline_skip_if_only_changed (docs/metadata/config paths regex) for the e2e-v2-gke test job, standardizing skip logic across all branches.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: promoting e2e-v2-gke from an optional job with file-specific triggers to a required pipelined test across multiple branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The check is not applicable. The PR modifies only CI configuration YAML files and does not change any Ginkgo test definitions or test names.
Test Structure And Quality ✅ Passed The check requires review of Ginkgo test code quality. This PR modifies only CI configuration YAML files, not test code. The check is not applicable.
Microshift Test Compatibility ✅ Passed This PR modifies only CI configuration YAML files to adjust when e2e-v2-gke test is triggered. No new Ginkgo e2e tests are added, so the MicroShift Test Compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains no new Ginkgo e2e tests. Changes are CI configuration only (YAML files defining test job trigger conditions). SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI test job configuration files, not deployment manifests, operator code, or controllers. No topology-aware scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI config files with zero code changes. OTE Stdout Contract check applies to code changes affecting binary output, not CI configuration.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI configuration YAML files. No new Ginkgo e2e tests are added, making this check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from csrwng and enxebre May 5, 2026 14:39
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@cblecker
Copy link
Copy Markdown
Member Author

cblecker commented May 5, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 5, 2026

[REHEARSALNOTIFIER]
@cblecker: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-v2-gke openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-release-4.22-e2e-v2-gke openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-release-4.23-e2e-v2-gke openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-release-5.0-e2e-v2-gke openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-release-5.1-e2e-v2-gke openshift/hypershift presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 5, 2026

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cblecker
Copy link
Copy Markdown
Member Author

cblecker commented May 5, 2026

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 5, 2026

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cblecker
Copy link
Copy Markdown
Member Author

cblecker commented May 5, 2026

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

openshift-merge-bot Bot commented May 5, 2026

@cblecker: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cblecker