Onboard openshift-eng/ship-hook

[petr-muller]

Summary by CodeRabbit

• Chores
  • Added CI/CD pipeline configuration for ship-hook, including build root, image build and resource sizing.
  • Configured automated test suites (verify, unit, integration).
  • Established approval workflows and merge controls requiring approved and lgtm labels with validation rules.
  • Set up Prow plugin integrations and trigger routing for automated PR handling.
  • Added an approver to the repository OWNERS to enable repository review/approval.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 66e4c32a-6bba-4ce0-8772-20c6fbb6ce0d

📥 Commits

Reviewing files that changed from the base of the PR and between 575058f and 8ab9e67.

⛔ Files ignored due to path filters (3)

• ci-operator/jobs/openshift-eng/ship-hook/OWNERS is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-eng/ship-hook/openshift-eng-ship-hook-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
• ci-operator/jobs/openshift-eng/ship-hook/openshift-eng-ship-hook-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (5)

• ci-operator/config/openshift-eng/ship-hook/OWNERS
• ci-operator/config/openshift-eng/ship-hook/openshift-eng-ship-hook-main.yaml
• core-services/prow/02_config/openshift-eng/ship-hook/OWNERS
• core-services/prow/02_config/openshift-eng/ship-hook/_pluginconfig.yaml
• core-services/prow/02_config/openshift-eng/ship-hook/_prowconfig.yaml

✅ Files skipped from review due to trivial changes (4)

• ci-operator/config/openshift-eng/ship-hook/OWNERS
• ci-operator/config/openshift-eng/ship-hook/openshift-eng-ship-hook-main.yaml
• core-services/prow/02_config/openshift-eng/ship-hook/_prowconfig.yaml
• core-services/prow/02_config/openshift-eng/ship-hook/OWNERS

🚧 Files skipped from review as they are similar to previous changes (1)

• core-services/prow/02_config/openshift-eng/ship-hook/_pluginconfig.yaml

---

Walkthrough

Adds CI operator manifests and Prow configs for the openshift-eng/ship-hook repository: CI build/test/promotion definitions, OWNERS entries, Prow plugin wiring (including external plugin endpoints), and Tide merge queries requiring approved and lgtm labels.

Changes

CI Operator Configuration

Layer / File(s)	Summary
Owners ci-operator/config/openshift-eng/ship-hook/OWNERS	Adds approvers entry with petr-muller.
Build / Images / Resources ci-operator/config/openshift-eng/ship-hook/openshift-eng-ship-hook-main.yaml	Defines build_root (Dockerfile.buildroot), an image (images/ship-hook/Dockerfile → ship-hook), promotion rule to ci:latest, and global resource requests (100m CPU, 200Mi memory) and memory limit (4Gi).
Test Jobs / Metadata ci-operator/config/openshift-eng/ship-hook/openshift-eng-ship-hook-main.yaml	Adds three test jobs (verify, unit, integration) running make targets in src and includes zz_generated_metadata (branch: main, org: openshift-eng, repo: ship-hook).

Prow Automation Configuration

Layer / File(s)	Summary
Owners core-services/prow/02_config/openshift-eng/ship-hook/OWNERS	Adds approvers entry with petr-muller.
Plugin Acts-as / External Plugins core-services/prow/02_config/openshift-eng/ship-hook/_pluginconfig.yaml	Enables lgtm_acts_as_approve and review_acts_as_lgtm, disables require_self_approval, configures external_plugins forwarding to three HTTP endpoints (refresh, needs-rebase, pipeline-controller) with specified event triggers, and allowlists built-in plugins for the repo.
Tide Merge Rules core-services/prow/02_config/openshift-eng/ship-hook/_prowconfig.yaml	Adds tide.queries entry requiring approved and lgtm labels and enumerates missingLabels that block merge evaluation (backports/unvalidated-commits, do-not-merge/*, jira/invalid-bug, needs-rebase, etc.).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Onboard openshift-eng/ship-hook' directly and clearly summarizes the main purpose of this pull request, which is to set up CI/CD configuration and Prow integration for the openshift-eng/ship-hook repository.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Check is not applicable. PR contains no Ginkgo test files or test name declarations. Changes are CI/Prow configuration files only.
Test Structure And Quality	✅ Passed	Custom check for Ginkgo test code quality is not applicable. PR contains only CI/CD configuration files (OWNERS, YAML configs) with no Go test code or Ginkgo tests.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests are added in this PR. The changes consist solely of configuration files (OWNERS, CI config, and Prow settings). This check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR contains only CI infrastructure configuration (OWNERS, YAML config files) with no Ginkgo e2e tests. SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes consist of CI/Prow configuration files and OWNERS files only. No deployment manifests, operator code, or controllers present. Check is not applicable.
Ote Binary Stdout Contract	✅ Passed	PR contains only CI/CD configuration files (YAML, OWNERS) with no Go source code. OTE Binary Stdout Contract check applies only to Go test binaries, which are not present in this PR.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds only YAML configuration and OWNERS files for ship-hook onboarding. No Ginkgo e2e tests (Go files) are being added, so the IPv6/disconnected check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@petr-muller: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-eng-ship-hook-main-images	openshift-eng/ship-hook	presubmit	Presubmit changed
pull-ci-openshift-eng-ship-hook-main-integration	openshift-eng/ship-hook	presubmit	Presubmit changed
pull-ci-openshift-eng-ship-hook-main-unit	openshift-eng/ship-hook	presubmit	Presubmit changed
pull-ci-openshift-eng-ship-hook-main-verify	openshift-eng/ship-hook	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[petr-muller]

/pj-rehearse

[openshift-merge-bot]

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift-eng/ship-hook/main/unit	8ab9e67	link	unknown	/pj-rehearse pull-ci-openshift-eng-ship-hook-main-unit
ci/rehearse/openshift-eng/ship-hook/main/integration	8ab9e67	link	unknown	/pj-rehearse pull-ci-openshift-eng-ship-hook-main-integration
ci/rehearse/openshift-eng/ship-hook/main/images	8ab9e67	link	unknown	/pj-rehearse pull-ci-openshift-eng-ship-hook-main-images
ci/rehearse/openshift-eng/ship-hook/main/verify	8ab9e67	link	unknown	/pj-rehearse pull-ci-openshift-eng-ship-hook-main-verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.